-
Notifications
You must be signed in to change notification settings - Fork 13.3k
resolve: Support imports of associated types and glob imports from traits #138712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
r? @wesleywiser rustbot has assigned @wesleywiser. Use |
HIR ty lowering was modified cc @fmease |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with lifting the restrictions from the resolver and with making HIR ty lowering responsible for dealing with it, although this PR would allow more code to compile under the unstable feature (trait T { type A; } use T::A;
would start compiling (notice the lack of any use sites of A
!)) plus glob imports, of course.
This deviates from the RFC. IIRC it's fine for me as a T-compiler member to approve such a change regardless and without T-lang input as long as we clearly state all of this in the tracking issue #134691, so any hypothetical future stabilization report and T-lang stabilization FCP can pick up on it.
@rustbot ready |
Follow up to #134754, part of #134691.
This PR also closes #138711 now.
Prohibiting
use Trait::AssocType;
at name resolution stage doesn't make sense, the name itself is perfectly resolveable.It's a type checker's problem that the necessary generic args are not passed when the imported
AssocType
is used, so an error should be reported there.And since we can import associated trait items now, glob imports from traits can also be allowed.