Do not feed anon const a type that references generics that it does not have #138256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HIR ty lowering was modified cc @fmease |
rustbot
added
S-waiting-on-review
BoxyUwU
reviewed
Mar 9, 2025
There was a problem hiding this comment.
This makes sense. It's not like such an anon const could even type check without itself being able to refer to generic parameters in the first place lol.
I guess the only reason we don't just delay a bug here is we have to feed something for the type_of and feeding an error const might cause us to just silence type checking errors for the anon const (e.g. we have no way to feed a type that is never equal to what the user could have written... I guess that's not true but no nice way)
Comment on lines
2314
to
2317
| // We also error if the type contains any regions as effectively any region will wind | ||
| // up as a region variable in mir borrowck. It would also be somewhat concerning if | ||
| // hir typeck was using equality but mir borrowck wound up using subtyping as that could | ||
| // result in a non-infer in hir typeck but a region variable in borrowck. |
There was a problem hiding this comment.
u moved this comment but I don't think this makes any sense here? this error is about non region stuff whereas the comment is about erroring on stuff involving regions
There was a problem hiding this comment.
Wrong comment on wrong block, meant to slice it up so each exception was commented individually but copied wrong lol
compiler-errors
force-pushed
the
anon-const-ty
branch
from
eb679ee to
3cd3df2
Compare
This comment has been minimized.
This comment has been minimized.
compiler-errors
force-pushed
the
anon-const-ty
branch
from
3cd3df2 to
ed6dfdd
Compare
|
This PR changes a file inside |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 11, 2025
…oxyUwU Do not feed anon const a type that references generics that it does not have Fixes rust-lang#137865 See the comment I left in the code. We could alternatively give these anon consts the generics from the parent, but that would be moving in a GCE-esque direction that we may not want. Open to tweaks here. r? BoxyUwU
This was referenced Mar 11, 2025
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 11, 2025
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#137715 (Allow int literals for pattern types with int base types) - rust-lang#138002 (Disable CFI for weakly linked syscalls) - rust-lang#138051 (Add support for downloading GCC from CI) - rust-lang#138231 (Prevent ICE in autodiff validation by emitting user-friendly errors) - rust-lang#138245 (stabilize `ci_rustc_if_unchanged_logic` test for local environments) - rust-lang#138256 (Do not feed anon const a type that references generics that it does not have) - rust-lang#138284 (Do not write user type annotation for const param value path) - rust-lang#138296 (Remove `AdtFlags::IS_ANONYMOUS` and `Copy`/`Clone` condition for anonymous ADT) - rust-lang#138352 (miri native_calls: ensure we actually expose *mutable* provenance to the memory FFI can access) - rust-lang#138354 (remove redundant `body` arguments) r? `@ghost` `@rustbot` modify labels: rollup
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Mar 14, 2025
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#137715 (Allow int literals for pattern types with int base types) - rust-lang#138002 (Disable CFI for weakly linked syscalls) - rust-lang#138051 (Add support for downloading GCC from CI) - rust-lang#138231 (Prevent ICE in autodiff validation by emitting user-friendly errors) - rust-lang#138245 (stabilize `ci_rustc_if_unchanged_logic` test for local environments) - rust-lang#138256 (Do not feed anon const a type that references generics that it does not have) - rust-lang#138284 (Do not write user type annotation for const param value path) - rust-lang#138296 (Remove `AdtFlags::IS_ANONYMOUS` and `Copy`/`Clone` condition for anonymous ADT) - rust-lang#138352 (miri native_calls: ensure we actually expose *mutable* provenance to the memory FFI can access) - rust-lang#138354 (remove redundant `body` arguments) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #137865
See the comment I left in the code. We could alternatively give these anon consts the generics from the parent, but that would be moving in a GCE-esque direction that we may not want. Open to tweaks here.
r? BoxyUwU