Skip to content

Update stdarch submodule #128866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Update stdarch submodule #128866

merged 1 commit into from
Aug 21, 2024

Conversation

scottmcm
Copy link
Member

@scottmcm scottmcm commented Aug 9, 2024

To pick up rust-lang/stdarch#1624 and unblock removing support for non-array-based-simd (rust-lang/compiler-team#621).

@rustbot
Copy link
Collaborator

rustbot commented Aug 9, 2024

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Aug 9, 2024

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 9, 2024
@scottmcm
Copy link
Member Author

scottmcm commented Aug 9, 2024

codegen CI tests passed, but let's make sure things are still happy with full LLVM and some other platforms
@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 9, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 9, 2024
Update stdarch submodule

To pick up rust-lang/stdarch#1624 and unblock removing support for non-array-based-simd (rust-lang/compiler-team#621).

try-job: dist-aarch64-linux
try-job: dist-armv7-linux
try-job: dist-x86_64-linux
@bors
Copy link
Collaborator

bors commented Aug 9, 2024

⌛ Trying commit 0ff2e7f with merge a373d86...

@bors
Copy link
Collaborator

bors commented Aug 9, 2024

☀️ Try build successful - checks-actions
Build commit: a373d86 (a373d86d5d5cb67978ab5a614aedec6ad77aa2fe)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a373d86): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.8% [0.8%, 0.8%] 1
Regressions ❌
(secondary)
0.9% [0.2%, 3.8%] 5
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.8% [0.8%, 0.8%] 1

Max RSS (memory usage)

Results (primary -0.3%, secondary 2.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.1% [0.5%, 3.7%] 5
Regressions ❌
(secondary)
2.6% [1.1%, 4.0%] 5
Improvements ✅
(primary)
-4.5% [-5.6%, -3.7%] 3
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.3% [-5.6%, 3.7%] 8

Cycles

Results (primary 0.6%, secondary 3.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.6% [0.6%, 0.6%] 1
Regressions ❌
(secondary)
3.1% [3.1%, 3.1%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.6% [0.6%, 0.6%] 1

Binary size

Results (primary 0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.2% [0.0%, 1.1%] 11
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.0% [-0.2%, -0.0%] 19
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.0% [-0.2%, 1.1%] 30

Bootstrap: 762.519s -> 759.669s (-0.37%)
Artifact size: 337.06 MiB -> 337.08 MiB (0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 9, 2024
@Amanieu
Copy link
Member

Amanieu commented Aug 9, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 9, 2024

📌 Commit 0ff2e7f has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 13, 2024
Update stdarch submodule

To pick up rust-lang/stdarch#1624 and unblock removing support for non-array-based-simd (rust-lang/compiler-team#621).

try-job: dist-aarch64-linux
try-job: dist-armv7-linux
try-job: dist-x86_64-linux
@bors
Copy link
Collaborator

bors commented Aug 13, 2024

⌛ Testing commit 0ff2e7f with merge 59db036...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented Aug 13, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 13, 2024
@tgross35
Copy link
Contributor

@scottmcm looks like this may have been fixed a couple of days ago rust-lang/stdarch#1630

@scottmcm
Copy link
Member Author

Updated to rust-lang/stdarch@d9466ed to pick up rust-lang/stdarch#1630 that fixed the dist-loongarch64-linux problem.

(And hopefully with rust-lang/stdarch#1631, these problems will be caught in stdarch CI in future, rather than here.)

@tgross35
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 21, 2024

📌 Commit 210f603 has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 21, 2024
@bors
Copy link
Collaborator

bors commented Aug 21, 2024

⌛ Testing commit 210f603 with merge 59a74db...

@bors
Copy link
Collaborator

bors commented Aug 21, 2024

☀️ Test successful - checks-actions
Approved by: tgross35
Pushing 59a74db to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 21, 2024
@bors bors merged commit 59a74db into rust-lang:master Aug 21, 2024
7 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Aug 21, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (59a74db): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.3% [0.2%, 0.5%] 2
Regressions ❌
(secondary)
0.2% [0.1%, 0.7%] 14
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.3% [0.2%, 0.5%] 2

Max RSS (memory usage)

Results (primary -2.6%, secondary 1.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.2% [0.5%, 1.8%] 2
Regressions ❌
(secondary)
1.6% [1.6%, 1.6%] 1
Improvements ✅
(primary)
-4.5% [-7.4%, -0.6%] 4
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.6% [-7.4%, 1.8%] 6

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results (primary 0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.1% [0.0%, 0.3%] 10
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.0% [-0.1%, -0.0%] 16
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.0% [-0.1%, 0.3%] 26

Bootstrap: 750.316s -> 750.629s (0.04%)
Artifact size: 338.93 MiB -> 338.97 MiB (0.01%)

@rustbot rustbot added the perf-regression Performance regression. label Aug 21, 2024
@lqd
Copy link
Member

lqd commented Aug 21, 2024

Mostly doc builds that get slower when core/std are updated.

@scottmcm scottmcm deleted the update-stdarch branch August 21, 2024 17:52
@pnkfelix
Copy link
Member

Visiting for weekly perf triage.

  • primary regressions are to cratelift-codegen llvm-opt-full and helloworld llvm-doc-full
  • from the graphs, the cranelift regression looks like a blip, and the helloworld regression seems tiny compared to other changes in its history -- I infer the auto-computed significance threshold is quite low here, probably because historically the build time for helloworld is very stable?
  • In any case, doesn't seem worth investigating. Marking as triaged.

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants