-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Update stdarch submodule #128866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update stdarch submodule #128866
Conversation
|
codegen CI tests passed, but let's make sure things are still happy with full LLVM and some other platforms |
This comment has been minimized.
This comment has been minimized.
Update stdarch submodule To pick up rust-lang/stdarch#1624 and unblock removing support for non-array-based-simd (rust-lang/compiler-team#621). try-job: dist-aarch64-linux try-job: dist-armv7-linux try-job: dist-x86_64-linux
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (a373d86): comparison URL. Overall result: ❌ regressions - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results (primary -0.3%, secondary 2.6%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 0.6%, secondary 3.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResults (primary 0.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 762.519s -> 759.669s (-0.37%) |
@bors r+ |
Update stdarch submodule To pick up rust-lang/stdarch#1624 and unblock removing support for non-array-based-simd (rust-lang/compiler-team#621). try-job: dist-aarch64-linux try-job: dist-armv7-linux try-job: dist-x86_64-linux
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
@scottmcm looks like this may have been fixed a couple of days ago rust-lang/stdarch#1630 |
0ff2e7f
to
210f603
Compare
Updated to rust-lang/stdarch@d9466ed to pick up rust-lang/stdarch#1630 that fixed the (And hopefully with rust-lang/stdarch#1631, these problems will be caught in stdarch CI in future, rather than here.) |
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (59a74db): comparison URL. Overall result: ❌ regressions - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results (primary -2.6%, secondary 1.6%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeResults (primary 0.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 750.316s -> 750.629s (0.04%) |
Mostly doc builds that get slower when core/std are updated. |
Visiting for weekly perf triage.
@rustbot label: +perf-regression-triaged |
To pick up rust-lang/stdarch#1624 and unblock removing support for non-array-based-simd (rust-lang/compiler-team#621).