Skip to content

Account for opaque variance in outlives #110399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 20, 2023
Merged

Account for opaque variance in outlives #110399

merged 3 commits into from
Apr 20, 2023

Conversation

cjgillot
Copy link
Contributor

Fixes #108591
Fixes #108592
cc @aliemjay

@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2023

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 16, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@oli-obk
Copy link
Contributor

oli-obk commented Apr 16, 2023

r? @aliemjay

@rustbot rustbot assigned aliemjay and unassigned oli-obk Apr 16, 2023
@aliemjay
Copy link
Member

Looks good. Thanks!
@bors r+

@bors
Copy link
Collaborator

bors commented Apr 19, 2023

📌 Commit 8fc1d68 has been approved by aliemjay

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 19, 2023
@bors
Copy link
Collaborator

bors commented Apr 20, 2023

⌛ Testing commit 8fc1d68 with merge 7fde083...

@bors
Copy link
Collaborator

bors commented Apr 20, 2023

☀️ Test successful - checks-actions
Approved by: aliemjay
Pushing 7fde083 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 20, 2023
@bors bors merged commit 7fde083 into rust-lang:master Apr 20, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 20, 2023
@cjgillot cjgillot deleted the infer-variance branch April 20, 2023 06:23
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (7fde083): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.4% [1.4%, 4.7%] 3
Improvements ✅
(primary)		 -3.5% [-3.5%, -3.5%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -3.5% [-3.5%, -3.5%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aliemjay aliemjay

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.

impl Trait lifetimes regression 1.67 part 2 impl Trait lifetimes regression 1.67
7 participants
@cjgillot @rustbot @rust-log-analyzer @oli-obk @aliemjay @bors @rust-timer