resurect shootout-mandelbrot.rs #10531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: * add licence; * remove usage of libc and unsafe; * use BufferedWriter to improve performance; * use a DummyWriter to cancel binary output in test.
| println!("P4\n{} {}", w, h); | ||
| let args = std::os::args(); | ||
| let (w, mut out) = if args.len() < 2 { | ||
| println("Test mode: do not dump the image."); |
There was a problem hiding this comment.
do not dump the image because it's not utf8, which interferes with the test runner, maybe?
| let args = std::os::args(); | ||
| let (w, mut out) = if args.len() < 2 { | ||
| println("Test mode: do not dump the image because it's not utf8," | ||
| + " which interferes with the test runner."); |
There was a problem hiding this comment.
You can break strings over multiple lines, and escape whitespace (i.e. the \n and the leading spaces of the next line) with \, i.e.
println("Test mode: do not dump the image because it's not utf8, \
which interferes with the test runner.");
bors
added a commit
that referenced
this pull request
Nov 17, 2013
Changes: * add licence; * remove usage of libc and unsafe; * use BufferedWriter to improve performance; * use a DummyWriter to cancel binary output in test.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 6, 2023
Add explanation on how to run `cargo-clippy` and `clippy-driver` I don't know how this would be done on Windows or MacOS, feedback appreciated. I did find this snippet for MacOS but it seems a little sketchy. https://github.com./rust-lang/rust-clippy/blob/1d1e72308e5bcdf5abe95c1d29dfe82524940061/.github/workflows/clippy_bors.yml#L98-L102 changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: