Rollup of 5 pull requests #102009
Closed
Rollup of 5 pull requests #102009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was added in 2a1bad7 to go with this module summary function: https://github.com./rust-lang/rust/blob/2a1bad70dd9bc99d8db54964108b42da8f4e9fbd/src/librustdoc/html/format.rs#L767-L780 The corresponding HTML was removed in 0a46933.
Tone down explanation on RefCell::get_mut
The language around `RefCell::get_mut` is remarkably sketchy and especially to the novice seems to quite strongly discourage using the method ("be cautious", "Also, please be aware", "special circumstances", "usually not what you want"). It was added six years ago in rust-lang#40634 due to confusion about when to use `get_mut` and `borrow_mut`.
While its signature limits the use-cases for `get_mut`, there is no chance for a safety footgun, and readers can be made aware of `borrow_mut` more softly. I've also just sent a [PR](rust-lang/rust-clippy#9044) to lint situations where `get_mut` could be used to improve ergonomics and performance.
So this PR tones down the language around `get_mut` and also brings it more in line with [`std::sync::Mutex::get_mut()`](https://doc.rust-lang.org/stable/std/sync/struct.Mutex.html#method.get_mut).
…, r=sanxiyn Remove an unused struct field `late_bound`
…mulacrum Add unit test for identifier Unicode emoji diagnostics Seems current diagnostics has some support for emoji usages, however it seems outdated and incomplete. This adds a simple unit test to showcase the status quo.
…rk-Simulacrum Update release notes for 1.64 This PR makes a few updates to the release notes to bring them on-par with the release notes of other releases: * The wording on some items has been changed to be more consistent and better describe what each change means, rather than using the PR title. * Items that were also in the compatibility notes have been removed from the other sections, only keeping them in the compat notes. * Diagnostics and ICE fixes have been removed from the notes. * The cargo section has been made more consistent. r? `@Mark-Simulacrum` cc `@rust-lang/release` `@joshtriplett`
…umn, r=Dylan-DPC rustdoc: remove unused CSS `td.summary-column` It was added in 2a1bad7 to go with this module summary function: https://github.com./rust-lang/rust/blob/2a1bad70dd9bc99d8db54964108b42da8f4e9fbd/src/librustdoc/html/format.rs#L767-L780 The corresponding HTML was removed in 0a46933.
rustbot
added
T-compiler
|
@bors r+ rollup=never p=5 |
bors
added
the
S-waiting-on-bors
|
will do a rollup later since the queue will increase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
late_bound#101881 (Remove an unused struct fieldlate_bound)td.summary-column#102005 (rustdoc: remove unused CSStd.summary-column)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup