-
Notifications
You must be signed in to change notification settings - Fork 13.3k
migration lint for use crate
fails with <Foo as Bar>::Baz
paths
#50970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this issue
May 22, 2018
This commit fixes another issue in the `absolute_path_not_starting_with_crate` lint where it warns twice about an import which may contain `self`. It turns out there were a few more locations that needed updating to use `root_id` and `root_span` introduced in rust-lang#50970 and after that it looks to work like a charm! Closes rust-lang#50978
Got the fix in a branch |
bors
added a commit
that referenced
this issue
May 23, 2018
rustc: Fix another double-lint issue with `crate::` This commit fixes another issue in the `absolute_path_not_starting_with_crate` lint where it warns twice about an import which may contain `self`. It turns out there were a few more locations that needed updating to use `root_id` and `root_span` introduced in #50970 and after that it looks to work like a charm! Closes #50978
nikomatsakis
added a commit
to nikomatsakis/rust
that referenced
this issue
May 23, 2018
bors
added a commit
that referenced
this issue
May 23, 2018
…h, r=alexcrichton Issue 50970 migration lint fq path Similar issue, but for fully qualified paths. Fixes #50970 r? @alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Test case:
This currently suggests:
but should suggest:
The text was updated successfully, but these errors were encountered: