-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Permissions in std::tempfile::mkdtemp #2349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hex We may just want to set it to |
I think this should definitely use |
Fixed in 0a8c039 |
Improve isatty support Per rust-lang/miri#2292 (comment), this is an attempt at > do something more clever with Miri's `isatty` shim Since Unix -> Unix is very simple, I'm starting with a patch that just does that. Happy to augment/rewrite this based on feedback. The linked file in libtest specifically only supports stdout. If we're doing this to support terminal applications, I think it would be strange to support one but not all 3 of the standard streams. The `atty` crate contains a bunch of extra logic that libtest does not contain, in order to support MSYS terminals: softprops/atty@db8d55f so I think if we're going to do Windows support, we should probably access all that logic somehow. I think it's pretty clear that the implementation is not going to change, so I think if we want to, pasting the contents of the `atty` crate into Miri is on the table, instead of taking a dependency.
Update our workspace dependencies by running cargo update.
There's a comment in
std::tempfile::mkdtemp
that says "FIXME: u+rwx". I assume the idea here is to set the r, w and x bits for U to 1 and leave other bits unchanged from the default, rather than setting the permissions for the new directory to a fixed bit pattern. But I don't really know the details of how permissions bits work, so I'm filing this.The text was updated successfully, but these errors were encountered: