Skip to content

Make std::sort::quick_sort3 take lt and eq types #2348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
catamorphism opened this issue May 3, 2012 · 1 comment
Closed

Make std::sort::quick_sort3 take lt and eq types #2348

catamorphism opened this issue May 3, 2012 · 1 comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Milestone
old 1.0 milestone

Comments

@catamorphism
Copy link
Contributor

Again, I'm not sure what is meant here, but quick_sort3 has a FIXME saying "This should take lt and eq types".
pcwalton added a commit that referenced this issue Jun 6, 2012
@pcwalton
stdlib: Introduce ord and eq interfaces. Make std::sort::quick_sort3 …
d9cddde 
…use them. i=#2348
@pcwalton
Copy link
Contributor

pcwalton commented Jun 6, 2012

Fixed.

@pcwalton pcwalton closed this as completed Jun 6, 2012
bors added a commit to rust-lang-ci/rust that referenced this issue Sep 22, 2022
@bors
Auto merge of rust-lang#2348 - RalfJung:ui-test, r=RalfJung
6bdc5d6 
ui_test: require colon after command

Turns out we already use colons everywhere properly.

Also rename ui_test::comments to parser. I think that better describes its contents. :)
celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@karkhaz
Add 'benchcomp visualize' & error on regression (rust-lang#2348)
94a26d1 
This commit adds an implementation for the `benchcomp visualize`
command. Currently, there is one visualization, "error_on_regression",
which causes `benchcomp` or `benchcomp visualize` to terminate with a
return code of 1 if there was a regression in any of the metrics.

Users can specify the following in their config file:

    visualize:
    - type: error_on_regression
      variant_pairs:
      - [variant_1, variant_2]
      - [variant_1, variant_3]
      checks:
      - metric: runtime
        test: "lambda old, new: new / old > 1.1"
      - metric: passed
        test: "lambda old, new: False if not old else not new"

This says to check whether any benchmark regressed when run under
variant_2 compared to variant_1. A benchmark is considered to have
regressed if the value of the 'runtime' metric under variant_2 is 10%
higher than the value under variant_1. Furthermore, the benchmark is
also considered to have regressed if it was previously passing, but is
now failing. These same checks are performed on all benchmarks run under
variant_3 compared to variant_1. If any of those lambda functions
returns True, then benchcomp will terminate with a return code of 1.

This commit fixes rust-lang#2338.
tshepang added a commit to tshepang/rust that referenced this issue Apr 21, 2025
@tshepang
Merge pull request rust-lang#2348 from rust-lang/tshepang-error-patte…
021ebcc 
…rn-cleaning

error-pattern directive section cleaning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
old 1.0 milestone
Development

No branches or pull requests
2 participants
@pcwalton @catamorphism