Tracking Issue for `naked_functions_target_rustic_abi` #138997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

4 tasks

folkertdev opened this issue Mar 26, 2025 · 0 comments

Open

4 tasks

Tracking Issue for `naked_functions_target_rustic_abi` #138997

folkertdev opened this issue Mar 26, 2025 · 0 comments

Labels

A-naked C-tracking-issue F-naked_functions

Contributor

folkertdev commented Mar 26, 2025

The feature gate for the issue is #![feature(naked_functions_target_rustic_abi)].

Because the details of the rust abi are unstable, and a naked function must match its stated ABI, this feature gate keeps naked functions with a rustic abi ("Rust", "rust-cold", "rust-call" and "rust-intrinsic") unstable.

Splitting out this feature was decided on in https://hackmd.io/20YsMoNgRjyxhBm_aVEwQg#Stabilize-naked_functions-rust134213.

About tracking issues

Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.
Discussion comments will get marked as off-topic or deleted.
Repeated discussions on the tracking issue may lead to the tracking issue getting locked.

Steps

Implement the RFC (cc @rust-lang/XXX -- can anyone write up mentoring
instructions?)
Adjust documentation (see instructions on rustc-dev-guide)
Formatting for new syntax has been added to the Style Guide (nightly-style-procedure)
Stabilization PR (see instructions on rustc-dev-guide)

Unresolved Questions

XXX --- list all the "unresolved questions" found in the RFC to ensure they are
not forgotten

Implementation history

@rustbot label +A-naked +F-naked_functions

folkertdev added the C-tracking-issue label

rustbot added A-naked F-naked_functions labels

folkertdev mentioned this issue

add naked_functions_rustic_abi feature gate #139001

Merged

folkertdev mentioned this issue

Make #[naked] an unsafe attribute #139753

Merged

ChrisDenton added a commit to ChrisDenton/rust that referenced this issue


          Rollup merge of rust-lang#139001 - folkertdev:naked-function-rustic-a…

7b2411c

…bi, r=traviscross,compiler-errors

add `naked_functions_rustic_abi` feature gate

tracking issue: rust-lang#138997

Because the details of the rust abi are unstable, and a naked function must match its stated ABI, this feature gate keeps naked functions with a rustic abi ("Rust", "rust-cold", "rust-call" and "rust-intrinsic") unstable.

r? `@traviscross`

ChrisDenton added a commit to ChrisDenton/rust that referenced this issue


          Rollup merge of rust-lang#139001 - folkertdev:naked-function-rustic-a…

d5a95ed

…bi, r=traviscross,compiler-errors

add `naked_functions_rustic_abi` feature gate

tracking issue: rust-lang#138997

Because the details of the rust abi are unstable, and a naked function must match its stated ABI, this feature gate keeps naked functions with a rustic abi ("Rust", "rust-cold", "rust-call" and "rust-intrinsic") unstable.

r? ``@traviscross``

jhpratt added a commit to jhpratt/rust that referenced this issue


          Rollup merge of rust-lang#139001 - folkertdev:naked-function-rustic-a…

60e3de7

…bi, r=traviscross,compiler-errors

add `naked_functions_rustic_abi` feature gate

tracking issue: rust-lang#138997

Because the details of the rust abi are unstable, and a naked function must match its stated ABI, this feature gate keeps naked functions with a rustic abi ("Rust", "rust-cold", "rust-call" and "rust-intrinsic") unstable.

r? ```@traviscross```

jhpratt added a commit to jhpratt/rust that referenced this issue


          Rollup merge of rust-lang#139001 - folkertdev:naked-function-rustic-a…

7f691d2

…bi, r=traviscross,compiler-errors

add `naked_functions_rustic_abi` feature gate

tracking issue: rust-lang#138997

Because the details of the rust abi are unstable, and a naked function must match its stated ABI, this feature gate keeps naked functions with a rustic abi ("Rust", "rust-cold", "rust-call" and "rust-intrinsic") unstable.

r? ````@traviscross````

rust-timer added a commit to rust-lang-ci/rust that referenced this issue


          Unrolled build for rust-lang#139001

80e749e

Rollup merge of rust-lang#139001 - folkertdev:naked-function-rustic-abi, r=traviscross,compiler-errors

add `naked_functions_rustic_abi` feature gate

tracking issue: rust-lang#138997

Because the details of the rust abi are unstable, and a naked function must match its stated ABI, this feature gate keeps naked functions with a rustic abi ("Rust", "rust-cold", "rust-call" and "rust-intrinsic") unstable.

r? ````@traviscross````

folkertdev mentioned this issue

Allow (but don't require) #[unsafe(naked)] so that compiler-builtins can upgrade to it #139797

Merged

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue


          Rollup merge of rust-lang#139797 - folkertdev:naked-allow-unsafe, r=t…

1bceed8

…gross35

Allow (but don't require) `#[unsafe(naked)]` so that `compiler-builtins` can upgrade to it

tracking issue: rust-lang#138997

Per rust-lang#134213 (comment), we want to make the `#[naked]` attribute an unsafe attribute. Making that change runs into a cyclic dependency with `compiler-builtins` which uses `#[naked]`, where `rustc` needs an updated `compiler-builtins` and vice versa.

So based on rust-lang#139753 and [#t-compiler/help > updating &rust-lang#96;compiler-builtins&rust-lang#96; and &rust-lang#96;rustc&rust-lang#96;](https://rust-lang.zulipchat.com/#narrow/channel/182449-t-compiler.2Fhelp/topic/updating.20.60compiler-builtins.60.20and.20.60rustc.60), this PR allows, but does not require `#[unsafe(naked)]`, and makes that change for some of the tests to check that both `#[naked]` and `#[unsafe(naked)]` are accepted.

Then we can upgrade and synchronize `compiler-builtins`, and then make `#[naked]` (without `unsafe`) invalid.

r? `@traviscross` (or someone from t-compiler if you're faster and this look allright)

Zalathar added a commit to Zalathar/rust that referenced this issue


          Rollup merge of rust-lang#139797 - folkertdev:naked-allow-unsafe, r=t…

312325b

…gross35

Allow (but don't require) `#[unsafe(naked)]` so that `compiler-builtins` can upgrade to it

tracking issue: rust-lang#138997

Per rust-lang#134213 (comment), we want to make the `#[naked]` attribute an unsafe attribute. Making that change runs into a cyclic dependency with `compiler-builtins` which uses `#[naked]`, where `rustc` needs an updated `compiler-builtins` and vice versa.

So based on rust-lang#139753 and [#t-compiler/help > updating &rust-lang#96;compiler-builtins&rust-lang#96; and &rust-lang#96;rustc&rust-lang#96;](https://rust-lang.zulipchat.com/#narrow/channel/182449-t-compiler.2Fhelp/topic/updating.20.60compiler-builtins.60.20and.20.60rustc.60), this PR allows, but does not require `#[unsafe(naked)]`, and makes that change for some of the tests to check that both `#[naked]` and `#[unsafe(naked)]` are accepted.

Then we can upgrade and synchronize `compiler-builtins`, and then make `#[naked]` (without `unsafe`) invalid.

r? ``@traviscross`` (or someone from t-compiler if you're faster and this look allright)

rust-timer added a commit to rust-lang-ci/rust that referenced this issue


          Unrolled build for rust-lang#139797

59ed346

Rollup merge of rust-lang#139797 - folkertdev:naked-allow-unsafe, r=tgross35

Allow (but don't require) `#[unsafe(naked)]` so that `compiler-builtins` can upgrade to it

tracking issue: rust-lang#138997

Per rust-lang#134213 (comment), we want to make the `#[naked]` attribute an unsafe attribute. Making that change runs into a cyclic dependency with `compiler-builtins` which uses `#[naked]`, where `rustc` needs an updated `compiler-builtins` and vice versa.

So based on rust-lang#139753 and [#t-compiler/help > updating &rust-lang#96;compiler-builtins&rust-lang#96; and &rust-lang#96;rustc&rust-lang#96;](https://rust-lang.zulipchat.com/#narrow/channel/182449-t-compiler.2Fhelp/topic/updating.20.60compiler-builtins.60.20and.20.60rustc.60), this PR allows, but does not require `#[unsafe(naked)]`, and makes that change for some of the tests to check that both `#[naked]` and `#[unsafe(naked)]` are accepted.

Then we can upgrade and synchronize `compiler-builtins`, and then make `#[naked]` (without `unsafe`) invalid.

r? `@traviscross` (or someone from t-compiler if you're faster and this look allright)

jhpratt added a commit to jhpratt/rust that referenced this issue


          Rollup merge of rust-lang#139753 - folkertdev:naked-function-unsafe-a…

73de020

…ttribute, r=tgross35,traviscross

Make `#[naked]` an unsafe attribute

tracking issue: rust-lang#138997

Per rust-lang#134213 (comment), the `#[naked]` attribute is now an unsafe attribute (in any edition).

This can only be merged when the above PRs are merged, I'd just like to see if there are any CI surprises here, and maybe there is early review feedback too.

r? `@traviscross`

ChrisDenton added a commit to ChrisDenton/rust that referenced this issue


          Rollup merge of rust-lang#139753 - folkertdev:naked-function-unsafe-a…

1a5e486

…ttribute, r=tgross35,traviscross

Make `#[naked]` an unsafe attribute

tracking issue: rust-lang#138997

Per rust-lang#134213 (comment), the `#[naked]` attribute is now an unsafe attribute (in any edition).

This can only be merged when the above PRs are merged, I'd just like to see if there are any CI surprises here, and maybe there is early review feedback too.

r? ``@traviscross``

rust-timer added a commit to rust-lang-ci/rust that referenced this issue


          Unrolled build for rust-lang#139753

c3a4e84

Rollup merge of rust-lang#139753 - folkertdev:naked-function-unsafe-attribute, r=tgross35,traviscross

Make `#[naked]` an unsafe attribute

tracking issue: rust-lang#138997

Per rust-lang#134213 (comment), the `#[naked]` attribute is now an unsafe attribute (in any edition).

This can only be merged when the above PRs are merged, I'd just like to see if there are any CI surprises here, and maybe there is early review feedback too.

r? ``@traviscross``

github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this issue


          Rollup merge of #139753 - folkertdev:naked-function-unsafe-attribute,…

82c3452

… r=tgross35,traviscross

Make `#[naked]` an unsafe attribute

tracking issue: rust-lang/rust#138997

Per rust-lang/rust#134213 (comment), the `#[naked]` attribute is now an unsafe attribute (in any edition).

This can only be merged when the above PRs are merged, I'd just like to see if there are any CI surprises here, and maybe there is early review feedback too.

r? ``@traviscross``

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment