Skip to content

Shorten backtraces in ICEs #107910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jyn514 opened this issue Feb 10, 2023 · 2 comments · Fixed by #108938
Closed

Shorten backtraces in ICEs #107910

jyn514 opened this issue Feb 10, 2023 · 2 comments · Fixed by #108938
Assignees
@chenyukang
Labels
A-contributor-roadblock Area: Makes things more difficult for new or seasoned contributors to Rust E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@jyn514
Copy link
Member

jyn514 commented Feb 10, 2023 •
edited by rustbot
Loading

Right now, the backtraces in an ICE are almost unreadably long (250+ frames, sometimes as much as 400+). See message.txt for an example.

Most of these frames are not particularly useful. Consider for example this snippet:

rustc_query_impl plumbing 
             3: <rustc_query_system::dep_graph::graph::DepGraph<rustc_middle::dep_graph::dep_node::DepKind>>::with_task_impl::<rustc_middle::ty::context::TyCtxt, (), std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>>::{closure#0}
                       at ./compiler/rustc_query_system/src/dep_graph/graph.rs:340:53
             4: rustc_middle::ty::context::tls::tlv::with_tlv::<<rustc_query_system::dep_graph::graph::DepGraph<rustc_middle::dep_graph::dep_node::DepKind>>::with_task_impl<rustc_middle::ty::context::TyCtxt, (), std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>>::{closure#0}, std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>>
                       at ./compiler/rustc_middle/src/ty/context/tls.rs:94:9
             5: rustc_middle::ty::context::tls::enter_context::<<rustc_query_system::dep_graph::graph::DepGraph<rustc_middle::dep_graph::dep_node::DepKind>>::with_task_impl<rustc_middle::ty::context::TyCtxt, (), std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>>::{closure#0}, std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>>
                       at ./compiler/rustc_middle/src/ty/context/tls.rs:114:5
             6: <rustc_middle::dep_graph::dep_node::DepKind as rustc_query_system::dep_graph::DepKind>::with_deps::<<rustc_query_system::dep_graph::graph::DepGraph<rustc_middle::dep_graph::dep_node::DepKind>>::with_task_impl<rustc_middle::ty::context::TyCtxt, (), std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>>::{closure#0}, std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>>::{closure#0}
                       at ./compiler/rustc_middle/src/dep_graph/mod.rs:58:13
             7: rustc_middle::ty::context::tls::with_context::<<rustc_middle::dep_graph::dep_node::DepKind as rustc_query_system::dep_graph::DepKind>::with_deps<<rustc_query_system::dep_graph::graph::DepGraph<rustc_middle::dep_graph::dep_node::DepKind>>::with_task_impl<rustc_middle::ty::context::TyCtxt, (), std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>>::{closure#0}, std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>>::{closure#0}, std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>>::{closure#0}
                       at ./compiler/rustc_middle/src/ty/context/tls.rs:142:36
             8: rustc_middle::ty::context::tls::with_context_opt::<rustc_middle::ty::context::tls::with_context<<rustc_middle::dep_graph::dep_node::DepKind as rustc_query_system::dep_graph::DepKind>::with_deps<<rustc_query_system::dep_graph::graph::DepGraph<rustc_middle::dep_graph::dep_node::DepKind>>::with_task_impl<rustc_middle::ty::context::TyCtxt, (), std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>>::{closure#0}, std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>>::{closure#0}, std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>>::{closure#0}, std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>>
                       at ./compiler/rustc_middle/src/ty/context/tls.rs:131:18
             9: rustc_middle::ty::context::tls::with_context::<<rustc_middle::dep_graph::dep_node::DepKind as rustc_query_system::dep_graph::DepKind>::with_deps<<rustc_query_system::dep_graph::graph::DepGraph<rustc_middle::dep_graph::dep_node::DepKind>>::with_task_impl<rustc_middle::ty::context::TyCtxt, (), std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>>::{closure#0}, std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>>::{closure#0}, std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>>
                       at ./compiler/rustc_middle/src/ty/context/tls.rs:142:5
            10: <rustc_middle::dep_graph::dep_node::DepKind as rustc_query_system::dep_graph::DepKind>::with_deps::<<rustc_query_system::dep_graph::graph::DepGraph<rustc_middle::dep_graph::dep_node::DepKind>>::with_task_impl<rustc_middle::ty::context::TyCtxt, (), std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>>::{closure#0}, std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>>
                       at ./compiler/rustc_middle/src/dep_graph/mod.rs:55:9
            11: <rustc_query_system::dep_graph::graph::DepGraph<rustc_middle::dep_graph::dep_node::DepKind>>::with_task_impl::<rustc_middle::ty::context::TyCtxt, (), std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>>
                       at ./compiler/rustc_query_system/src/dep_graph/graph.rs:340:22
            12: <rustc_query_system::dep_graph::graph::DepGraph<rustc_middle::dep_graph::dep_node::DepKind>>::with_task::<rustc_middle::ty::context::TyCtxt, (), std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>>
                       at ./compiler/rustc_query_system/src/dep_graph/graph.rs:290:13
            13: rustc_query_system::query::plumbing::execute_job::<rustc_query_impl::queries::trimmed_def_paths, rustc_query_impl::plumbing::QueryCtxt>::{closure#3}
                       at ./compiler/rustc_query_system/src/query/plumbing.rs:467:13
            14: stacker::maybe_grow::<(std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>, rustc_query_system::dep_graph::graph::DepNodeIndex), rustc_query_system::query::plumbing::execute_job<rustc_query_impl::queries::trimmed_def_paths, rustc_query_impl::plumbing::QueryCtxt>::{closure#3}>
                       at /home/gh-yaahc/.cargo/registry/src/github.com.-1ecc6299db9ec823/stacker-0.1.15/src/lib.rs:55:9
            15: rustc_data_structures::stack::ensure_sufficient_stack::<(std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>, rustc_query_system::dep_graph::graph::DepNodeIndex), rustc_query_system::query::plumbing::execute_job<rustc_query_impl::queries::trimmed_def_paths, rustc_query_impl::plumbing::QueryCtxt>::{closure#3}>
                       at ./compiler/rustc_data_structures/src/stack.rs:17:5
            16: <rustc_query_impl::plumbing::QueryCtxt as rustc_query_system::query::QueryContext>::start_query::<(std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>, rustc_query_system::dep_graph::graph::DepNodeIndex), rustc_query_system::query::plumbing::execute_job<rustc_query_impl::queries::trimmed_def_paths, rustc_query_impl::plumbing::QueryCtxt>::{closure#3}>::{closure#0}::{closure#0}
                       at ./compiler/rustc_query_impl/src/plumbing.rs:128:17
            17: rustc_middle::ty::context::tls::tlv::with_tlv::<<rustc_query_impl::plumbing::QueryCtxt as rustc_query_system::query::QueryContext>::start_query<(std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>, rustc_query_system::dep_graph::graph::DepNodeIndex), rustc_query_system::query::plumbing::execute_job<rustc_query_impl::queries::trimmed_def_paths, rustc_query_impl::plumbing::QueryCtxt>::{closure#3}>::{closure#0}::{closure#0}, (std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>, rustc_query_system::dep_graph::graph::DepNodeIndex)>
                       at ./compiler/rustc_middle/src/ty/context/tls.rs:94:9
            18: rustc_middle::ty::context::tls::enter_context::<<rustc_query_impl::plumbing::QueryCtxt as rustc_query_system::query::QueryContext>::start_query<(std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>, rustc_query_system::dep_graph::graph::DepNodeIndex), rustc_query_system::query::plumbing::execute_job<rustc_query_impl::queries::trimmed_def_paths, rustc_query_impl::plumbing::QueryCtxt>::{closure#3}>::{closure#0}::{closure#0}, (std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>, rustc_query_system::dep_graph::graph::DepNodeIndex)>
                       at ./compiler/rustc_middle/src/ty/context/tls.rs:114:5
            19: <rustc_query_impl::plumbing::QueryCtxt as rustc_query_system::query::QueryContext>::start_query::<(std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>, rustc_query_system::dep_graph::graph::DepNodeIndex), rustc_query_system::query::plumbing::execute_job<rustc_query_impl::queries::trimmed_def_paths, rustc_query_impl::plumbing::QueryCtxt>::{closure#3}>::{closure#0}
                       at ./compiler/rustc_query_impl/src/plumbing.rs:127:13
            20: rustc_middle::ty::context::tls::with_related_context::<<rustc_query_impl::plumbing::QueryCtxt as rustc_query_system::query::QueryContext>::start_query<(std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>, rustc_query_system::dep_graph::graph::DepNodeIndex), rustc_query_system::query::plumbing::execute_job<rustc_query_impl::queries::trimmed_def_paths, rustc_query_impl::plumbing::QueryCtxt>::{closure#3}>::{closure#0}, (std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>, rustc_query_system::dep_graph::graph::DepNodeIndex)>::{closure#0}
                       at ./compiler/rustc_middle/src/ty/context/tls.rs:164:9
            21: rustc_middle::ty::context::tls::with_context::<rustc_middle::ty::context::tls::with_related_context<<rustc_query_impl::plumbing::QueryCtxt as rustc_query_system::query::QueryContext>::start_query<(std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>, rustc_query_system::dep_graph::graph::DepNodeIndex), rustc_query_system::query::plumbing::execute_job<rustc_query_impl::queries::trimmed_def_paths, rustc_query_impl::plumbing::QueryCtxt>::{closure#3}>::{closure#0}, (std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>, rustc_query_system::dep_graph::graph::DepNodeIndex)>::{closure#0}, (std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>, rustc_query_system::dep_graph::graph::DepNodeIndex)>::{closure#0}
                       at ./compiler/rustc_middle/src/ty/context/tls.rs:142:36
            22: rustc_middle::ty::context::tls::with_context_opt::<rustc_middle::ty::context::tls::with_context<rustc_middle::ty::context::tls::with_related_context<<rustc_query_impl::plumbing::QueryCtxt as rustc_query_system::query::QueryContext>::start_query<(std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>, rustc_query_system::dep_graph::graph::DepNodeIndex), rustc_query_system::query::plumbing::execute_job<rustc_query_impl::queries::trimmed_def_paths, rustc_query_impl::plumbing::QueryCtxt>::{closure#3}>::{closure#0}, (std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>, rustc_query_system::dep_graph::graph::DepNodeIndex)>::{closure#0}, (std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>, rustc_query_system::dep_graph::graph::DepNodeIndex)>::{closure#0}, (std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>, rustc_query_system::dep_graph::graph::DepNodeIndex)>
                       at ./compiler/rustc_middle/src/ty/context/tls.rs:131:18
            23: rustc_middle::ty::context::tls::with_context::<rustc_middle::ty::context::tls::with_related_context<<rustc_query_impl::plumbing::QueryCtxt as rustc_query_system::query::QueryContext>::start_query<(std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>, rustc_query_system::dep_graph::graph::DepNodeIndex), rustc_query_system::query::plumbing::execute_job<rustc_query_impl::queries::trimmed_def_paths, rustc_query_impl::plumbing::QueryCtxt>::{closure#3}>::{closure#0}, (std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>, rustc_query_system::dep_graph::graph::DepNodeIndex)>::{closure#0}, (std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>, rustc_query_system::dep_graph::graph::DepNodeIndex)>
                       at ./compiler/rustc_middle/src/ty/context/tls.rs:142:5
            24: rustc_middle::ty::context::tls::with_related_context::<<rustc_query_impl::plumbing::QueryCtxt as rustc_query_system::query::QueryContext>::start_query<(std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>, rustc_query_system::dep_graph::graph::DepNodeIndex), rustc_query_system::query::plumbing::execute_job<rustc_query_impl::queries::trimmed_def_paths, rustc_query_impl::plumbing::QueryCtxt>::{closure#3}>::{closure#0}, (std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>, rustc_query_system::dep_graph::graph::DepNodeIndex)>
                       at ./compiler/rustc_middle/src/ty/context/tls.rs:155:5
            25: <rustc_query_impl::plumbing::QueryCtxt as rustc_query_system::query::QueryContext>::start_query::<(std::collections::hash::map::HashMap<rustc_span::def_id::DefId, rustc_span::symbol::Symbol, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>, rustc_query_system::dep_graph::graph::DepNodeIndex), rustc_query_system::query::plumbing::execute_job<rustc_query_impl::queries::trimmed_def_paths, rustc_query_impl::plumbing::QueryCtxt>::{closure#3}>
                       at ./compiler/rustc_query_impl/src/plumbing.rs:112:9
            26: rustc_query_system::query::plumbing::execute_job::<rustc_query_impl::queries::trimmed_def_paths, rustc_query_impl::plumbing::QueryCtxt>
                       at ./compiler/rustc_query_system/src/query/plumbing.rs:455:9
            27: rustc_query_system::query::plumbing::try_execute_query::<rustc_query_impl::queries::trimmed_def_paths, rustc_query_impl::plumbing::QueryCtxt>
                       at ./compiler/rustc_query_system/src/query/plumbing.rs:369:17
            28: rustc_query_system::query::plumbing::force_query::<rustc_query_impl::queries::trimmed_def_paths, rustc_query_impl::plumbing::QueryCtxt, rustc_middle::dep_graph::dep_node::DepKind>
                       at ./compiler/rustc_query_system/src/query/plumbing.rs:779:5
            29: rustc_query_impl::plumbing::force_from_dep_node::<rustc_query_impl::queries::trimmed_def_paths>
                       at ./compiler/rustc_query_impl/src/plumbing.rs:408:9
            30: <rustc_middle::ty::context::TyCtxt as rustc_query_system::dep_graph::DepContext>::try_force_from_dep_node
                       at ./compiler/rustc_query_system/src/dep_graph/mod.rs:59:13
            31: <rustc_query_system::dep_graph::graph::DepGraph<rustc_middle::dep_graph::dep_node::DepKind>>::try_mark_parent_green::<rustc_query_impl::plumbing::QueryCtxt>
                       at ./compiler/rustc_query_system/src/dep_graph/graph.rs:736:13
            32: <rustc_query_system::dep_graph::graph::DepGraph<rustc_middle::dep_graph::dep_node::DepKind>>::try_mark_previous_green::<rustc_query_impl::plumbing::QueryCtxt>
                       at ./compiler/rustc_query_system/src/dep_graph/graph.rs:797:13
            33: <rustc_query_system::dep_graph::graph::DepGraph<rustc_middle::dep_graph::dep_node::DepKind>>::try_mark_parent_green::<rustc_query_impl::plumbing::QueryCtxt>
                       at ./compiler/rustc_query_system/src/dep_graph/graph.rs:726:17
            34: <rustc_query_system::dep_graph::graph::DepGraph<rustc_middle::dep_graph::dep_node::DepKind>>::try_mark_previous_green::<rustc_query_impl::plumbing::QueryCtxt>
                       at ./compiler/rustc_query_system/src/dep_graph/graph.rs:797:13
            35: <rustc_query_system::dep_graph::graph::DepGraph<rustc_middle::dep_graph::dep_node::DepKind>>::try_mark_parent_green::<rustc_query_impl::plumbing::QueryCtxt>
                       at ./compiler/rustc_query_system/src/dep_graph/graph.rs:726:17
            36: <rustc_query_system::dep_graph::graph::DepGraph<rustc_middle::dep_graph::dep_node::DepKind>>::try_mark_previous_green::<rustc_query_impl::plumbing::QueryCtxt>
                       at ./compiler/rustc_query_system/src/dep_graph/graph.rs:797:13
            37: <rustc_query_system::dep_graph::graph::DepGraph<rustc_middle::dep_graph::dep_node::DepKind>>::try_mark_parent_green::<rustc_query_impl::plumbing::QueryCtxt>
                       at ./compiler/rustc_query_system/src/dep_graph/graph.rs:726:17
            38: <rustc_query_system::dep_graph::graph::DepGraph<rustc_middle::dep_graph::dep_node::DepKind>>::try_mark_previous_green::<rustc_query_impl::plumbing::QueryCtxt>
                       at ./compiler/rustc_query_system/src/dep_graph/graph.rs:797:13
            39: <rustc_query_system::dep_graph::graph::DepGraph<rustc_middle::dep_graph::dep_node::DepKind>>::try_mark_parent_green::<rustc_query_impl::plumbing::QueryCtxt>
                       at ./compiler/rustc_query_system/src/dep_graph/graph.rs:726:17
            40: <rustc_query_system::dep_graph::graph::DepGraph<rustc_middle::dep_graph::dep_node::DepKind>>::try_mark_previous_green::<rustc_query_impl::plumbing::QueryCtxt>
                       at ./compiler/rustc_query_system/src/dep_graph/graph.rs:797:13
            41: <rustc_query_system::dep_graph::graph::DepGraph<rustc_middle::dep_graph::dep_node::DepKind>>::try_mark_parent_green::<rustc_query_impl::plumbing::QueryCtxt>
                       at ./compiler/rustc_query_system/src/dep_graph/graph.rs:726:17
            42: <rustc_query_system::dep_graph::graph::DepGraph<rustc_middle::dep_graph::dep_node::DepKind>>::try_mark_previous_green::<rustc_query_impl::plumbing::QueryCtxt>
                       at ./compiler/rustc_query_system/src/dep_graph/graph.rs:797:13
            43: <rustc_query_system::dep_graph::graph::DepGraph<rustc_middle::dep_graph::dep_node::DepKind>>::try_mark_parent_green::<rustc_query_impl::plumbing::QueryCtxt>
                       at ./compiler/rustc_query_system/src/dep_graph/graph.rs:726:17
            44: <rustc_query_system::dep_graph::graph::DepGraph<rustc_middle::dep_graph::dep_node::DepKind>>::try_mark_previous_green::<rustc_query_impl::plumbing::QueryCtxt>
                       at ./compiler/rustc_query_system/src/dep_graph/graph.rs:797:13
            45: <rustc_query_system::dep_graph::graph::DepGraph<rustc_middle::dep_graph::dep_node::DepKind>>::try_mark_parent_green::<rustc_query_impl::plumbing::QueryCtxt>
                       at ./compiler/rustc_query_system/src/dep_graph/graph.rs:726:17
            46: <rustc_query_system::dep_graph::graph::DepGraph<rustc_middle::dep_graph::dep_node::DepKind>>::try_mark_previous_green::<rustc_query_impl::plumbing::QueryCtxt>
                       at ./compiler/rustc_query_system/src/dep_graph/graph.rs:797:13
            47: <rustc_query_system::dep_graph::graph::DepGraph<rustc_middle::dep_graph::dep_node::DepKind>>::try_mark_parent_green::<rustc_query_impl::plumbing::QueryCtxt>
                       at ./compiler/rustc_query_system/src/dep_graph/graph.rs:726:17
            48: <rustc_query_system::dep_graph::graph::DepGraph<rustc_middle::dep_graph::dep_node::DepKind>>::try_mark_previous_green::<rustc_query_impl::plumbing::QueryCtxt>
                       at ./compiler/rustc_query_system/src/dep_graph/graph.rs:797:13
            49: <rustc_query_system::dep_graph::graph::DepGraph<rustc_middle::dep_graph::dep_node::DepKind>>::try_mark_parent_green::<rustc_query_impl::plumbing::QueryCtxt>
                       at ./compiler/rustc_query_system/src/dep_graph/graph.rs:726:17
            50: <rustc_query_system::dep_graph::graph::DepGraph<rustc_middle::dep_graph::dep_node::DepKind>>::try_mark_previous_green::<rustc_query_impl::plumbing::QueryCtxt>
                       at ./compiler/rustc_query_system/src/dep_graph/graph.rs:797:13
            51: <rustc_query_system::dep_graph::graph::DepGraph<rustc_middle::dep_graph::dep_node::DepKind>>::try_mark_green::<rustc_query_impl::plumbing::QueryCtxt>
                       at ./compiler/rustc_query_system/src/dep_graph/graph.rs:681:17
            52: rustc_query_system::query::plumbing::try_load_from_disk_and_cache_in_memory::<rustc_query_impl::queries::type_of, rustc_query_impl::plumbing::QueryCtxt>
                       at ./compiler/rustc_query_system/src/query/plumbing.rs:499:49
            53: rustc_query_system::query::plumbing::execute_job::<rustc_query_impl::queries::type_of, rustc_query_impl::plumbing::QueryCtxt>::{closure#2}
                       at ./compiler/rustc_query_system/src/query/plumbing.rs:445:13
            54: stacker::maybe_grow::<core::option::Option<(rustc_middle::ty::Ty, rustc_query_system::dep_graph::graph::DepNodeIndex)>, rustc_query_system::query::plumbing::execute_job<rustc_query_impl::queries::type_of, rustc_query_impl::plumbing::QueryCtxt>::{closure#2}>
                       at /home/gh-yaahc/.cargo/registry/src/github.com.-1ecc6299db9ec823/stacker-0.1.15/src/lib.rs:55:9
            55: rustc_data_structures::stack::ensure_sufficient_stack::<core::option::Option<(rustc_middle::ty::Ty, rustc_query_system::dep_graph::graph::DepNodeIndex)>, rustc_query_system::query::plumbing::execute_job<rustc_query_impl::queries::type_of, rustc_query_impl::plumbing::QueryCtxt>::{closure#2}>
                       at ./compiler/rustc_data_structures/src/stack.rs:17:5
            56: <rustc_query_impl::plumbing::QueryCtxt as rustc_query_system::query::QueryContext>::start_query::<core::option::Option<(rustc_middle::ty::Ty, rustc_query_system::dep_graph::graph::DepNodeIndex)>, rustc_query_system::query::plumbing::execute_job<rustc_query_impl::queries::type_of, rustc_query_impl::plumbing::QueryCtxt>::{closure#2}>::{closure#0}::{closure#0}
                       at ./compiler/rustc_query_impl/src/plumbing.rs:128:17
            57: rustc_middle::ty::context::tls::tlv::with_tlv::<<rustc_query_impl::plumbing::QueryCtxt as rustc_query_system::query::QueryContext>::start_query<core::option::Option<(rustc_middle::ty::Ty, rustc_query_system::dep_graph::graph::DepNodeIndex)>, rustc_query_system::query::plumbing::execute_job<rustc_query_impl::queries::type_of, rustc_query_impl::plumbing::QueryCtxt>::{closure#2}>::{closure#0}::{closure#0}, core::option::Option<(rustc_middle::ty::Ty, rustc_query_system::dep_graph::graph::DepNodeIndex)>>
                       at ./compiler/rustc_middle/src/ty/context/tls.rs:94:9
            58: rustc_middle::ty::context::tls::enter_context::<<rustc_query_impl::plumbing::QueryCtxt as rustc_query_system::query::QueryContext>::start_query<core::option::Option<(rustc_middle::ty::Ty, rustc_query_system::dep_graph::graph::DepNodeIndex)>, rustc_query_system::query::plumbing::execute_job<rustc_query_impl::queries::type_of, rustc_query_impl::plumbing::QueryCtxt>::{closure#2}>::{closure#0}::{closure#0}, core::option::Option<(rustc_middle::ty::Ty, rustc_query_system::dep_graph::graph::DepNodeIndex)>>
                       at ./compiler/rustc_middle/src/ty/context/tls.rs:114:5
            59: <rustc_query_impl::plumbing::QueryCtxt as rustc_query_system::query::QueryContext>::start_query::<core::option::Option<(rustc_middle::ty::Ty, rustc_query_system::dep_graph::graph::DepNodeIndex)>, rustc_query_system::query::plumbing::execute_job<rustc_query_impl::queries::type_of, rustc_query_impl::plumbing::QueryCtxt>::{closure#2}>::{closure#0}
                       at ./compiler/rustc_query_impl/src/plumbing.rs:127:13
            60: rustc_middle::ty::context::tls::with_related_context::<<rustc_query_impl::plumbing::QueryCtxt as rustc_query_system::query::QueryContext>::start_query<core::option::Option<(rustc_middle::ty::Ty, rustc_query_system::dep_graph::graph::DepNodeIndex)>, rustc_query_system::query::plumbing::execute_job<rustc_query_impl::queries::type_of, rustc_query_impl::plumbing::QueryCtxt>::{closure#2}>::{closure#0}, core::option::Option<(rustc_middle::ty::Ty, rustc_query_system::dep_graph::graph::DepNodeIndex)>>::{closure#0}
                       at ./compiler/rustc_middle/src/ty/context/tls.rs:164:9
            61: rustc_middle::ty::context::tls::with_context::<rustc_middle::ty::context::tls::with_related_context<<rustc_query_impl::plumbing::QueryCtxt as rustc_query_system::query::QueryContext>::start_query<core::option::Option<(rustc_middle::ty::Ty, rustc_query_system::dep_graph::graph::DepNodeIndex)>, rustc_query_system::query::plumbing::execute_job<rustc_query_impl::queries::type_of, rustc_query_impl::plumbing::QueryCtxt>::{closure#2}>::{closure#0}, core::option::Option<(rustc_middle::ty::Ty, rustc_query_system::dep_graph::graph::DepNodeIndex)>>::{closure#0}, core::option::Option<(rustc_middle::ty::Ty, rustc_query_system::dep_graph::graph::DepNodeIndex)>>::{closure#0}
                       at ./compiler/rustc_middle/src/ty/context/tls.rs:142:36
            62: rustc_middle::ty::context::tls::with_context_opt::<rustc_middle::ty::context::tls::with_context<rustc_middle::ty::context::tls::with_related_context<<rustc_query_impl::plumbing::QueryCtxt as rustc_query_system::query::QueryContext>::start_query<core::option::Option<(rustc_middle::ty::Ty, rustc_query_system::dep_graph::graph::DepNodeIndex)>, rustc_query_system::query::plumbing::execute_job<rustc_query_impl::queries::type_of, rustc_query_impl::plumbing::QueryCtxt>::{closure#2}>::{closure#0}, core::option::Option<(rustc_middle::ty::Ty, rustc_query_system::dep_graph::graph::DepNodeIndex)>>::{closure#0}, core::option::Option<(rustc_middle::ty::Ty, rustc_query_system::dep_graph::graph::DepNodeIndex)>>::{closure#0}, core::option::Option<(rustc_middle::ty::Ty, rustc_query_system::dep_graph::graph::DepNodeIndex)>>
                       at ./compiler/rustc_middle/src/ty/context/tls.rs:131:18
            63: rustc_middle::ty::context::tls::with_context::<rustc_middle::ty::context::tls::with_related_context<<rustc_query_impl::plumbing::QueryCtxt as rustc_query_system::query::QueryContext>::start_query<core::option::Option<(rustc_middle::ty::Ty, rustc_query_system::dep_graph::graph::DepNodeIndex)>, rustc_query_system::query::plumbing::execute_job<rustc_query_impl::queries::type_of, rustc_query_impl::plumbing::QueryCtxt>::{closure#2}>::{closure#0}, core::option::Option<(rustc_middle::ty::Ty, rustc_query_system::dep_graph::graph::DepNodeIndex)>>::{closure#0}, core::option::Option<(rustc_middle::ty::Ty, rustc_query_system::dep_graph::graph::DepNodeIndex)>>
                       at ./compiler/rustc_middle/src/ty/context/tls.rs:142:5
            64: rustc_middle::ty::context::tls::with_related_context::<<rustc_query_impl::plumbing::QueryCtxt as rustc_query_system::query::QueryContext>::start_query<core::option::Option<(rustc_middle::ty::Ty, rustc_query_system::dep_graph::graph::DepNodeIndex)>, rustc_query_system::query::plumbing::execute_job<rustc_query_impl::queries::type_of, rustc_query_impl::plumbing::QueryCtxt>::{closure#2}>::{closure#0}, core::option::Option<(rustc_middle::ty::Ty, rustc_query_system::dep_graph::graph::DepNodeIndex)>>
                       at ./compiler/rustc_middle/src/ty/context/tls.rs:155:5
            65: <rustc_query_impl::plumbing::QueryCtxt as rustc_query_system::query::QueryContext>::start_query::<core::option::Option<(rustc_middle::ty::Ty, rustc_query_system::dep_graph::graph::DepNodeIndex)>, rustc_query_system::query::plumbing::execute_job<rustc_query_impl::queries::type_of, rustc_query_impl::plumbing::QueryCtxt>::{closure#2}>
                       at ./compiler/rustc_query_impl/src/plumbing.rs:112:9
            66: rustc_query_system::query::plumbing::execute_job::<rustc_query_impl::queries::type_of, rustc_query_impl::plumbing::QueryCtxt>
                       at ./compiler/rustc_query_system/src/query/plumbing.rs:444:28
            67: rustc_query_system::query::plumbing::try_execute_query::<rustc_query_impl::queries::type_of, rustc_query_impl::plumbing::QueryCtxt>
                       at ./compiler/rustc_query_system/src/query/plumbing.rs:369:17
            68: rustc_query_system::query::plumbing::get_query::<rustc_query_impl::queries::type_of, rustc_query_impl::plumbing::QueryCtxt, rustc_middle::dep_graph::dep_node::DepKind>
                       at ./compiler/rustc_query_system/src/query/plumbing.rs:747:36
            69: <rustc_query_impl::Queries as rustc_middle::ty::query::QueryEngine>::type_of::{closure#0}
                       at ./compiler/rustc_query_impl/src/plumbing.rs:730:17
            70: <rustc_query_impl::Queries as rustc_middle::ty::query::QueryEngine>::type_of
                       at ./compiler/rustc_query_impl/src/lib.rs:44:1

The only useful information here is "the type_of query was run", but it takes up 140 lines and 70 frames of the backtrace.
We should collapse these unless the user opts-in: I'm imagining something like setting RUSTC_BACKTRACE=1 which hides the frames by default and RUSTC_BACKTRACE=full which expands them.
@jyn514 jyn514 added A-contributor-roadblock Area: Makes things more difficult for new or seasoned contributors to Rust T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 10, 2023
@jyn514
Copy link
Member Author

jyn514 commented Feb 10, 2023

rust/library/std/src/sys_common/backtrace.rs

Lines 76 to 80 in 4aa6afa

if start && sym.contains("__rust_begin_short_backtrace") {
stop = true;
return;
}
if sym.contains("__rust_end_short_backtrace") {
looks like it will work for any function named __rust_begin_short_backtrace, not just the one in std, so it might be as simple as adding an inline(never) function with that name at

rust/compiler/rustc_query_impl/src/plumbing.rs

Line 730 in 4e163af

get_query::<queries::$name<'tcx>, _, rustc_middle::dep_graph::DepKind>(qcx, span, key, mode)
and

rust/compiler/rustc_query_system/src/dep_graph/graph.rs

Line 340 in 4aa6afa

let result = K::with_deps(task_deps_ref, || task(cx, arg));

@jyn514 jyn514 added E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. labels Feb 10, 2023
@chenyukang
Copy link
Member

@rustbot claim

@jyn514 jyn514 mentioned this issue Feb 15, 2023
Closed
chenyukang added a commit to chenyukang/rust that referenced this issue Mar 9, 2023
@chenyukang
Fix rust-lang#107910, Shorten backtraces in ICEs
1e80402
@chenyukang chenyukang mentioned this issue Mar 9, 2023
Merged
chenyukang added a commit to chenyukang/rust that referenced this issue May 14, 2023
@chenyukang
Fix rust-lang#107910, Shorten backtraces in ICEs
5c41569
bors added a commit to rust-lang-ci/rust that referenced this issue May 18, 2023
@bors
Auto merge of rust-lang#108938 - chenyukang:yukang/fix-107910-shorten…
77c836e 
…-ice, r=cjgillot

Shorten backtraces for queries in ICEs

r? `@jyn514`
Fixes rust-lang#107910
@bors bors closed this as completed in c3394b3 May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chenyukang chenyukang

Labels
A-contributor-roadblock Area: Makes things more difficult for new or seasoned contributors to Rust E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Shorten backtraces for queries in ICEs chenyukang/rust
2 participants
@chenyukang @jyn514