Skip to content

Clarify interaction of asm-goto with IBT #1790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 27, 2025
Merged

Conversation

nbdd0121
Copy link
Contributor

Document the restriction that the asm-goto labels should not be jumped to indirectly if there's an architectural distinction (e.g. x64 with IBT).

This restriction is in place for rustc_codegen_gcc, and for LLVM, it's currently allowed, but https://discourse.llvm.org/t/rfc-asm-goto-vs-branch-target-enforcement/85845 may disallow this in the future.

This is to clarify rust-lang/rust#119364 (comment). cc @programmerjake

@rustbot rustbot added the S-waiting-on-review Status: The marked PR is awaiting review from a maintainer label Apr 15, 2025
@traviscross
Copy link
Contributor

@rfcbot fcp merge

@rfcbot
Copy link

rfcbot commented Apr 16, 2025

Team member @traviscross has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns.
See this document for info about what commands tagged team members can give me.

@joshtriplett
Copy link
Member

joshtriplett commented Apr 16, 2025

This looks reasonable. Hopefully in the future there will be a label indirect mechanism or similar.

@rfcbot reviewed

@nikomatsakis
Copy link
Contributor

@rfcbot reviewed

1 similar comment
@tmandry
Copy link
Member

tmandry commented Apr 16, 2025

@rfcbot reviewed

@rfcbot
Copy link

rfcbot commented Apr 16, 2025

🔔 This is now entering its final comment period, as per the review above. 🔔

psst @traviscross, I wasn't able to add the final-comment-period label, please do so.

@rustbot

This comment has been minimized.

@rfcbot
Copy link

rfcbot commented Apr 26, 2025

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

psst @traviscross, I wasn't able to add the finished-final-comment-period label, please do so.

@traviscross traviscross removed the S-waiting-on-review Status: The marked PR is awaiting review from a maintainer label Apr 27, 2025
@traviscross traviscross added this pull request to the merge queue Apr 27, 2025
Merged via the queue into rust-lang:master with commit e72ac2a Apr 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants