Faster docker development #2470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
GuillaumeGomez
approved these changes
Mar 26, 2024
Nemo157
force-pushed
the
faster-docker-dev
branch
from
62d6380 to
b75dd2d
Compare
|
So this also affects CI times, it significantly slows down the clean build because of optimizing all dependencies, but speeds up the incremental build a little (though that is dominated by times that it doesn't affect), it also slightly reduces the cache size (by ~5%).
|
Nemo157
force-pushed
the
faster-docker-dev
branch
from
4cca883 to
b75dd2d
Compare
|
Still looks good to me. 👍 |
syphar
approved these changes
Apr 2, 2024
Unless you're doing clean builds all the time, having optimized dependencies and reducing the debuginfo generated for them is faster because it makes the linker do less work. Bump cache key because this replaces all cached dependencies
This improves turnaround speed when locally testing changes that require rebuilding the docker image.
Nemo157
force-pushed
the
faster-docker-dev
branch
from
b75dd2d to
257b92f
Compare
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a set of various changes I did to make working on the UI faster while using a docker-compose instance. Overall it about halved the time between changing a
templates/stylefile and being able to view the result for me afterdocker compose up -d --build web. (And allows changing the JS on the fly and just reloading the page).