Skip to content
This repository was archived by the owner on Oct 23, 2022. It is now read-only.

Enable 2 conformance timeout tests #287

Closed
wants to merge 1 commit into from

Conversation

ljedrz
Copy link
Member

@ljedrz ljedrz commented Aug 6, 2020

I noticed that we have 2 seemingly simple conformance tests disabled. I wanted to take a stab at fixing them, but try as I may, I can't trigger any hangs, so they might already have been fixed by some of our recent changes; let's see how they fare with the CI.

@ljedrz
Copy link
Member Author

ljedrz commented Aug 6, 2020

A kad timeout and some npm 404s 🙄; will rerun once all builds complete.

@ljedrz
Copy link
Member Author

ljedrz commented Aug 6, 2020

bors retry

@koivunej
Copy link
Collaborator

koivunej commented Aug 6, 2020

What has changed for these tests to no longer hang?

@ljedrz
Copy link
Member Author

ljedrz commented Aug 6, 2020

Good question - no clue, but I can't reproduce the hangs at all 🤔.

@koivunej
Copy link
Collaborator

koivunej commented Aug 6, 2020

I think last time they happened on windows and I guess you are not testing on windows, which prompted the addition of why-is-node-running and later the creation of ipfs/js-ipfsd-ctl#525 and the following up PR (which we have patched at the moment). Note regarding the timeout tests, and why I don't think they are too important at the moment: ipfs/js-ipfs#3161.

Lets do a few windows runs.

@ljedrz
Copy link
Member Author

ljedrz commented Aug 6, 2020

I think last time they happened on windows

Yeah, I'm on Linux so I wouldn't have this issue; if it still happens, I'll add this info to the comment, as I don't think this was specified (otherwise I wouldn't have attempted this at all 😛).

@ljedrz
Copy link
Member Author

ljedrz commented Aug 6, 2020

Aaah, this still doesn't have that kad fix 😆; I'll rebase.

@ljedrz ljedrz force-pushed the leftover_simple_conformance branch from e56bae7 to d30665c Compare August 6, 2020 13:03
@koivunej
Copy link
Collaborator

koivunej commented Aug 6, 2020

Re-running.

@ljedrz
Copy link
Member Author

ljedrz commented Aug 6, 2020

Re-running again.

Copy link
Collaborator

@koivunej koivunej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this was helped by the suprocess waiting.

I think there might still be general issues with the timeout tests not testing anything. Did you test that these tests actually work? I can't remember implementing a timeout for id or version.

@ljedrz
Copy link
Member Author

ljedrz commented Aug 31, 2020

Closing this as we're not convinced that passing these tests properly displays progress.

@ljedrz ljedrz closed this Aug 31, 2020
@ljedrz ljedrz deleted the leftover_simple_conformance branch August 31, 2020 13:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants