-
Notifications
You must be signed in to change notification settings - Fork 169
Conversation
A |
bors retry |
What has changed for these tests to no longer hang? |
Good question - no clue, but I can't reproduce the hangs at all 🤔. |
I think last time they happened on windows and I guess you are not testing on windows, which prompted the addition of why-is-node-running and later the creation of ipfs/js-ipfsd-ctl#525 and the following up PR (which we have patched at the moment). Note regarding the timeout tests, and why I don't think they are too important at the moment: ipfs/js-ipfs#3161. Lets do a few windows runs. |
Yeah, I'm on Linux so I wouldn't have this issue; if it still happens, I'll add this info to the comment, as I don't think this was specified (otherwise I wouldn't have attempted this at all 😛). |
Aaah, this still doesn't have that kad fix 😆; I'll rebase. |
Signed-off-by: ljedrz <[email protected]>
e56bae7
to
d30665c
Compare
Re-running. |
Re-running again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this was helped by the suprocess waiting.
I think there might still be general issues with the timeout tests not testing anything. Did you test that these tests actually work? I can't remember implementing a timeout for id or version.
Closing this as we're not convinced that passing these tests properly displays progress. |
I noticed that we have 2 seemingly simple conformance tests disabled. I wanted to take a stab at fixing them, but try as I may, I can't trigger any hangs, so they might already have been fixed by some of our recent changes; let's see how they fare with the CI.