Changes default cache embedding model #326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerhutcherson
approved these changes
Apr 23, 2025
| @@ -111,8 +111,19 @@ def __init__( | |||
| if dtype: | |||
| vectorizer_kwargs.update(dtype=dtype) | |||
|
|
|||
| # raise a warning to inform users we changed the default model | |||
| # remove this warning in future releases | |||
| logger.warning( | |||
There was a problem hiding this comment.
With the warning below in the case of pre-existing index AND overwrite=True, I don't think we actually need this one here right?
There was a problem hiding this comment.
You're right that a mismatch won't happen in that case, but there still is a behavior change when we switch default models. It's why I had to update the tests because the embedding distances changed.
There was a problem hiding this comment.
If someone goes from 0.5 to 0.6 and never specifies a vectorizer, and runs the same script start to finish - writes/reads/clears - they may get different results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the default semantic cache embedding model to our fine tuned model.