-
Notifications
You must be signed in to change notification settings - Fork 2.4k
feat: Add support for new redis command CLIENT NO-TOUCH #2551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Update commands_test.go
Update commands.go
move: commands to StatusCmd
@monkey92t hey, could you please review this one? |
Based on my understanding, this is a client state, not a regular command. It labels a network connection, and we should figure out how to handle similar commands. |
@monkey92t @SoulPancake
type baseClient struct {
...
connPool pool.Pooler // This here
Needs some more thought but what comes to my mind on the fly is either one of those...
// ClientNoTouch /or any other labeling command/ Creates and tags a new connection and returns it for use
cl := redis.ClientNoTouch()
cl.Get(...)
cl.Close()
|
Hello @ktsivkov, would you like to resurrect this discussion and start over? If so, let me know. If you don't have the time or don't plan to work on this, let's close the PR. |
Issue: #2519