This repository was archived by the owner on Jul 19, 2019. It is now read-only.
(feat) Chart.js 2.0-dev compatibility #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I edited your PR comment slightly to reflect "jhudson8/react-chartjs#chartjs-v2" |
|
Okay, great! Let me know if there's anything else I can do. |
| @@ -110,8 +119,10 @@ return /******/ (function(modules) { // webpackBootstrap | |||
|
|
|||
| classData.componentDidMount = function() { | |||
| this.initializeChart(this.props); | |||
| console.log(this.props); | |||
There was a problem hiding this comment.
Should probably get rid of this console.log()
There was a problem hiding this comment.
Oh, forgot about that one! Gone now.
|
Thank you! Upward and onward! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reading about Chart.js 2.0's performance upgrades, I've updated react-chartjs to be compatible with the Chart.js most up to date 2.0-dev branch, including the new bubble and scatter charts. By moving from 1.0.2 to 2.0, the time it takes a simple line-chart to render has dropped significantly.
Since people may still want to use Chart.js v1.0.2., if you don't want to merge yet people can still use this version by updating their dependencies in their project's package.json to:
"chart.js": "git://github.com./danmolitor/Chart.js.git#v2.0-dev",
"react-chartjs": "git+https://github.com./jhudson8/react-chartjs#chartjs-v2"
I've attached a image showing the original charts using Chart.js v2.0-dev.