Resolve Missing Deploy Target in Windows #311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asklar
approved these changes
Oct 16, 2020
vonovak
approved these changes
Oct 17, 2020
|
thank you! |
vonovak
pushed a commit
that referenced
this pull request
Oct 17, 2020
## [3.0.4](v3.0.3...v3.0.4) (2020-10-17) ### Bug Fixes * Resolve Missing Deploy Target in Windows ([#311](#311)) ([5c8d7b0](5c8d7b0))
|
🎉 This PR is included in version 3.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix error produced when module is added to a React Native app and run in Windows emulator.
Error reads: "The target "Deploy" does not exist in the project".
Test Plan
Create a React Native Windows app.
Add datetimepicker module to app via
yarn add.Run
npx react-native run-windows.If app deploys successfully and loads in the Windows emulator, the code change has succeeded.
What's required for testing (prerequisites)?
A React Native Windows app. See here for setup instructions.
What are the steps to reproduce (after prerequisites)?
To reproduce error, run steps under "Test Plan" with old version of the module.
Compatibility
Checklist
README.mdexample/App.js)