Skip to content

fix: tvOS support #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 7, 2020
Merged

fix: tvOS support #451

merged 2 commits into from
Oct 7, 2020

Conversation

krizzu
Copy link
Member

@krizzu krizzu commented Sep 30, 2020

Summary:

Bringing back tvOS support that was lost some time ago. Fixes #416

Test Plan:

Green CI.
Test AsyncStorage on tvOS

@krizzu
Copy link
Member Author

krizzu commented Oct 6, 2020

@tido64 Hey, mind having a quick look at this?

tido64
tido64 approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@tido64 tido64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a minor nit.

@krizzu krizzu merged commit 8e6c8cb into master Oct 7, 2020
@krizzu krizzu deleted the fix/tv-ios branch January 18, 2021 10:38
@dependabot dependabot bot mentioned this pull request Mar 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tido64 tido64 tido64 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Async-storage doesn't work on tvOS
2 participants
@krizzu @tido64