Skip to content

fix: (host-setup) properly set and pin the desired kernel #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

rackerchris
Copy link
Contributor

pin-kernel task wasnt actaully pinning the desired kernel but rather checking to see if it wasin the same major/minor series. This pr defines a static kernel and ensures that its installed and "pinned" via GRUB_DEFAULT updates.

@rackerchris rackerchris changed the title fix: (kernel) properly set and pin the desired kernel fix: (host-setup) properly set and pin the desired kernel Mar 24, 2025
Copy link
Contributor

@cloudnull cloudnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker if folks feel strongly about it, but I don't think we want to be in the business of doing kernel pinning. IMHO, as a project, we should only be setting our minimum requirements.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -18,44 +18,59 @@
filter: "ansible_kernel"

- name: Check Kernel Version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the intent of this check was to ensure that the deployed kernel on a given host met our minimum requirements. If we go down the path of pinning to a specific kernel version, we can eliminate this task.

host_required_kernel: 6.8.0-0-generic
# This variable is used to set the default kernel in grub. Ensure you are
# using the ENTIRE output from uname -r
host_required_kernel: 6.8.0-47-generic
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest kernel in this series is 6.8.0-56-generic if we're going down the path of doing specific kernel pinning, I don't think we should start out with an older version of the kernel that contains known CVEs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to create an opt-out interface for the task that calls this file; thinking of how we might need to run other kernel versions like linux-image-6.8.0-1006-intel for some of the accelerator work we're aiming to release in flex in the not so distant future.

@rackerchris rackerchris marked this pull request as draft March 25, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants