-
Notifications
You must be signed in to change notification settings - Fork 48
fix: (host-setup) properly set and pin the desired kernel #920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocker if folks feel strongly about it, but I don't think we want to be in the business of doing kernel pinning. IMHO, as a project, we should only be setting our minimum requirements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we'll need an equal configuration setup for debian defined here
@@ -18,44 +18,59 @@ | |||
filter: "ansible_kernel" | |||
|
|||
- name: Check Kernel Version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the intent of this check was to ensure that the deployed kernel on a given host met our minimum requirements. If we go down the path of pinning to a specific kernel version, we can eliminate this task.
host_required_kernel: 6.8.0-0-generic | ||
# This variable is used to set the default kernel in grub. Ensure you are | ||
# using the ENTIRE output from uname -r | ||
host_required_kernel: 6.8.0-47-generic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest kernel in this series is 6.8.0-56-generic
if we're going down the path of doing specific kernel pinning, I don't think we should start out with an older version of the kernel that contains known CVEs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be good to create an opt-out interface for the task that calls this file; thinking of how we might need to run other kernel versions like linux-image-6.8.0-1006-intel
for some of the accelerator work we're aiming to release in flex in the not so distant future.
pin-kernel task wasnt actaully pinning the desired kernel but rather checking to see if it wasin the same major/minor series. This pr defines a static kernel and ensures that its installed and "pinned" via GRUB_DEFAULT updates.