Download checkpoints from HuggingFace #9538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9538
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 19cda10 with merge base 655895f ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jackzhxng
force-pushed
the
jz/rename-phi4
branch
from
2f3ea4a to
69a4fbc
Compare
jackzhxng
force-pushed
the
jz/hf-download
branch
from
51ea275 to
7e32025
Compare
jackzhxng
added
the
release notes: examples
jackzhxng
force-pushed
the
jz/hf-download
branch
from
7e32025 to
73ae18a
Compare
jackzhxng
force-pushed
the
jz/rename-phi4
branch
from
69a4fbc to
e58ce7e
Compare
jackzhxng
force-pushed
the
jz/hf-download
branch
from
73ae18a to
e38c4ec
Compare
jackzhxng
force-pushed
the
jz/rename-phi4
branch
from
e58ce7e to
6afd1c0
Compare
jackzhxng
force-pushed
the
jz/hf-download
branch
from
e38c4ec to
3de41ce
Compare
jackzhxng
commented
Mar 24, 2025
|
|
||
| convert_weights(checkpoint_path, converted_path) | ||
| elif modelname == "smollm2": | ||
| pass |
There was a problem hiding this comment.
The PR for this is still getting in
tarun292
reviewed
Mar 24, 2025
| @@ -519,7 +523,53 @@ def canonical_path(path: Union[str, Path], *, dir: bool = False) -> str: | |||
| return return_val | |||
|
|
|||
|
|
|||
| def download_and_convert_hf_checkpoint(modelname: str) -> str: | |||
There was a problem hiding this comment.
Put this in a separate util file? I think it'll be useful elsewhere too potentially and also this file is getting quite bloated too i think.
tarun292
approved these changes
Mar 24, 2025
jackzhxng
force-pushed
the
jz/rename-phi4
branch
from
6afd1c0 to
205fb56
Compare
jackzhxng
requested review from
JacobSzwejbka,
larryliu0820 and
digantdesai
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If no checkpoint is specified during
export_llama, download the checkpoint from HuggingFace if it is an OSS model.Closes #8872
Test plan
Manual export