Arm backend: Don't handle const placeholders in match_arg_ranks_pass #9134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pass did previously handle constant placeholders directly by modifying the data in the state_dict, whereas call_functions are handled by inserting view ops. Since the introduction of the FuseConsantOpsPass however, ops acting on constant placeholders are computed AOT and fused into one single node. We can therefore now handle all nodes the same way here by inserting view nodes, removing the need for a special case in this pass. Change-Id: If282eea352205e1b0b10b9b747642fa0d6caa4b3
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9134
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 2 Cancelled JobsAs of commit 0b965bb with merge base ddf0d9e ( NEW FAILURE - The following job has failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@pytorchbot label "topic: not user facing" |
|
@pytorchbot label ciflow/trunk |
|
Didn't find following labels among repository labels: partner:arm |
|
@pytorchbot label "partner: arm" |
pytorch-bot
bot
added
the
partner: arm
|
@digantdesai, @kimishpatel can you please take a look? |
zingo
approved these changes
Mar 17, 2025
|
macos fails unrelated |
DannyYuyang-quic
pushed a commit
to CodeLinaro/executorch
that referenced
this pull request
Apr 2, 2025
…ytorch#9134) This pass did previously handle constant placeholders directly by modifying the data in the state_dict, whereas call_functions are handled by inserting view ops. Since the introduction of the FuseConsantOpsPass however, ops acting on constant placeholders are computed AOT and fused into one single node. We can therefore now handle all nodes the same way here by inserting view nodes, removing the need for a special case in this pass. Signed-off-by: Martin Lindström <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pass did previously handle constant placeholders directly by modifying the data in the state_dict, whereas call_functions are handled by inserting view ops. Since the introduction of the FuseConsantOpsPass however, ops acting on constant placeholders are computed AOT and fused into one single node.
We can therefore now handle all nodes the same way here by inserting view nodes, removing the need for a special case in this pass.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218