Skip to content

Migrate thread_parallel.cpp to ET_CHECK_OR_RETURN_FALSE #8977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Mar 7, 2025
Merged

Migrate thread_parallel.cpp to ET_CHECK_OR_RETURN_FALSE #8977

merged 32 commits into from
Mar 7, 2025

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Mar 5, 2025

It's convenient if this thing doesn't depend on tensor_util, and conveniently the dependency was deprecated anyway.

swolchok added 22 commits March 4, 2025 11:35
@swolchok
Update
d0b11e8 
[ghstack-poisoned]
@swolchok
Update
9437be1 
[ghstack-poisoned]
@swolchok
Update
643e10e 
[ghstack-poisoned]
@swolchok
Update
6f2842b 
[ghstack-poisoned]
@swolchok
Update
e47dfeb 
[ghstack-poisoned]
@swolchok
Update
231ebc3 
[ghstack-poisoned]
@swolchok
Update
296513c 
[ghstack-poisoned]
@swolchok
Update
845a01e 
[ghstack-poisoned]
@swolchok
Update
a92958a 
[ghstack-poisoned]
@swolchok
Update
3fa99d6 
[ghstack-poisoned]
@swolchok
Update
a6c69a6 
[ghstack-poisoned]
@swolchok
Update
3bd6437 
[ghstack-poisoned]
@swolchok
Update
675f01b 
[ghstack-poisoned]
@swolchok
Update
5f3a768 
[ghstack-poisoned]
@swolchok
Update
9fdebee 
[ghstack-poisoned]
@swolchok
Update
70a7096 
[ghstack-poisoned]
@swolchok
Update
337dc23 
[ghstack-poisoned]
@swolchok
Update
f388177 
[ghstack-poisoned]
@swolchok
Update
2949daf 
[ghstack-poisoned]
@swolchok
Update
7347915 
[ghstack-poisoned]
@swolchok
Update
1a8481d 
[ghstack-poisoned]
@swolchok
Update
e48e816 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Mar 5, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@swolchok swolchok requested a review from kimishpatel as a code owner March 5, 2025 22:40
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 5, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8977

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a8a0e57 with merge base 484231c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@swolchok swolchok mentioned this pull request Mar 5, 2025
Merged
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 5, 2025
@swolchok swolchok mentioned this pull request Mar 5, 2025
Merged
swolchok added a commit that referenced this pull request Mar 5, 2025
@swolchok
Migrate thread_parallel.cpp to ET_CHECK_OR_RETURN_FALSE
8e16793 
It's convenient if this thing doesn't depend on tensor_util, and conveniently the dependency was deprecated anyway.

ghstack-source-id: acbd298
ghstack-comment-id: 2702239582
Pull Request resolved: #8977
@swolchok swolchok mentioned this pull request Mar 6, 2025
Merged
swolchok added 3 commits March 5, 2025 19:37
@swolchok
Update
a1aeae7 
[ghstack-poisoned]
@swolchok
Update
c658163 
[ghstack-poisoned]
@swolchok
Update
7e0ccd4 
[ghstack-poisoned]
kimishpatel
kimishpatel reviewed Mar 6, 2025
View reviewed changes
extension/parallel/targets.bzl
"//executorch/runtime/core/exec_aten/util:tensor_util" + aten_suffix,
],
)
runtime.cxx_library(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont know the details on aten variant but are you removing it because you determined that it is not needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it was only needed because of the aten-suffixed tensor_util dep, which is gone now

@swolchok swolchok requested a review from kimishpatel March 6, 2025 03:40
swolchok added 3 commits March 6, 2025 09:56
@swolchok
Update
754a4f6 
[ghstack-poisoned]
@swolchok
Update
11c5707 
[ghstack-poisoned]
@swolchok
Update
7ca7627 
[ghstack-poisoned]
@swolchok swolchok mentioned this pull request Mar 6, 2025
Merged
swolchok added 4 commits March 7, 2025 09:48
@swolchok
Update
b478275 
[ghstack-poisoned]
@swolchok
Update
0470870 
[ghstack-poisoned]
@swolchok
Update
5a283c8 
[ghstack-poisoned]
@swolchok
Update
a8a0e57 
[ghstack-poisoned]
@swolchok swolchok mentioned this pull request Mar 7, 2025
Merged
Base automatically changed from gh/swolchok/308/head to main March 7, 2025 20:38
@swolchok swolchok merged commit 156f9fe into main Mar 7, 2025
49 checks passed
@swolchok swolchok deleted the gh/swolchok/314/head branch March 7, 2025 20:39
@github-actions github-actions bot mentioned this pull request Mar 10, 2025
Open
This was referenced Mar 17, 2025
Open
Open
@github-actions github-actions bot mentioned this pull request Mar 31, 2025
Open
@github-actions github-actions bot mentioned this pull request Apr 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimishpatel kimishpatel kimishpatel approved these changes

@jackzhxng jackzhxng Awaiting requested review from jackzhxng jackzhxng is a code owner

@iseeyuan iseeyuan Awaiting requested review from iseeyuan iseeyuan is a code owner

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@kirklandsign kirklandsign Awaiting requested review from kirklandsign kirklandsign is a code owner

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

@GregoryComer GregoryComer Awaiting requested review from GregoryComer GregoryComer is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swolchok @kimishpatel @facebook-github-bot