[Fix bug] always run prepare-test-spec #8974
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8974
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 3 PendingAs of commit 71e0775 with merge base 5ac4a3c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
yangw-dev
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
yangw-dev
had a problem deploying
to
upload-benchmark-results
GitHub Actions
Failure
yangw-dev
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
yangw-dev
had a problem deploying
to
upload-benchmark-results
GitHub Actions
Failure
|
got it! |
This was referenced Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up with #8125
Example of failed benchmark run: https://github.com./pytorch/executorch/actions/runs/13666476394
We made prepare-test-spec have dependency on export-model, it seems like when there is any failure happens in the export model step, it will skip the whole prepare-test-spec. We want to always run prepare-test-spec.
in step prepare-test-spec, we will check wether the export-model successfully build the model, if not, no test-spec will be uploaded. This makes the final step mobile-on-device step fails early at verify-test-spec part