Skip to content

Default ExecuTorch targets to ExecuTorch-wide Buck visibility #8969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Mar 5, 2025

IMO, Buck visibility is just inverse deps. We should trust that people have a good reason to add deps rather than attempt to police them and require double entry in both deps and visibility, especially since we seem to be committed to APIs by default in OSS anyway.

Specific motivation is that #8712 would otherwise have to ad-hoc slap ExecuTorch-wide visibility on a lot of targets, but I've held this view for a long time.

Differential Revision: D70647462

[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Mar 5, 2025

Copy link

pytorch-bot bot commented Mar 5, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8969

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ea92179 with merge base 6346348 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 5, 2025
@swolchok swolchok added the release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. label Mar 5, 2025
@mergennachin
Copy link
Contributor

mergennachin commented Mar 5, 2025

Can we make this consistent both internally in fbsource and shim layer?

Otherwise, a package could be potentially be private in fbsource but visible to ET in OSS, which could lead to diff train issues

@mergennachin
Copy link
Contributor

Oh wait, is this file shim_et/xplat/executorch/build/runtime_wrapper.bzl actually the same file used both internally and externally?

@swolchok
Copy link
Contributor Author

swolchok commented Mar 5, 2025

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@swolchok
Copy link
Contributor Author

swolchok commented Mar 5, 2025

Oh wait, is this file shim_et/xplat/executorch/build/runtime_wrapper.bzl actually the same file used both internally and externally?

yes. (also it appears the default visibility is PUBLIC in OSS)

@swolchok swolchok merged commit b3f97aa into main Mar 5, 2025
51 of 54 checks passed
@swolchok swolchok deleted the gh/swolchok/313/head branch March 5, 2025 21:26
zonglinpeng pushed a commit that referenced this pull request Mar 6, 2025
IMO, Buck visibility is just inverse deps. We should trust that people have a good reason to add deps rather than attempt to police them and require double entry in both deps and visibility, especially since we seem to be committed to APIs by default in OSS anyway.

Specific motivation is that #8712 would otherwise have to ad-hoc slap ExecuTorch-wide visibility on a lot of targets, but I've held this view for a long time.

Differential Revision: D70647462
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants