-
Notifications
You must be signed in to change notification settings - Fork 527
Default ExecuTorch targets to ExecuTorch-wide Buck visibility #8969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8969
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ea92179 with merge base 6346348 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Can we make this consistent both internally in fbsource and shim layer? Otherwise, a package could be potentially be private in fbsource but visible to ET in OSS, which could lead to diff train issues |
Oh wait, is this file |
@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
yes. (also it appears the default visibility is |
IMO, Buck visibility is just inverse deps. We should trust that people have a good reason to add deps rather than attempt to police them and require double entry in both deps and visibility, especially since we seem to be committed to APIs by default in OSS anyway. Specific motivation is that #8712 would otherwise have to ad-hoc slap ExecuTorch-wide visibility on a lot of targets, but I've held this view for a long time. Differential Revision: D70647462
IMO, Buck visibility is just inverse deps. We should trust that people have a good reason to add deps rather than attempt to police them and require double entry in both
deps
andvisibility
, especially since we seem to be committed to APIs by default in OSS anyway.Specific motivation is that #8712 would otherwise have to ad-hoc slap ExecuTorch-wide visibility on a lot of targets, but I've held this view for a long time.
Differential Revision: D70647462