-
Notifications
You must be signed in to change notification settings - Fork 527
portable arg{max,min}: optimize update check #8863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8863
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 3143085 with merge base 09ad20a ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Mar 1, 2025
Merged
This was referenced Mar 3, 2025
7cbe7a1
to
7bc4529
Compare
7bc4529
to
764977b
Compare
(just rebased the branch, but tests were all green right before) |
manuelcandales
approved these changes
Mar 4, 2025
zonglinpeng
pushed a commit
that referenced
this pull request
Mar 6, 2025
We don't need a second isnan; see code comment. (This is a small optimization.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
release notes: ops & kernels
Changes to the opset and any new / changed kernel implementations
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need a second isnan; see code comment. (This is a small optimization.)