Skip to content

portable arg{max,min}: optimize update check #8863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 4, 2025
Merged

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Mar 1, 2025

We don't need a second isnan; see code comment. (This is a small optimization.)

@swolchok
Copy link
Contributor Author

swolchok commented Mar 1, 2025

@swolchok swolchok requested a review from manuelcandales as a code owner March 1, 2025 01:16
Copy link

pytorch-bot bot commented Mar 1, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8863

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 3143085 with merge base 09ad20a (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 1, 2025
swolchok added a commit that referenced this pull request Mar 3, 2025
We don't need a second isnan; see code comment. (This is a small optimization.)

ghstack-comment-id: 2686527528

ghstack-source-id: 0c3d3ae
ghstack-comment-id: 2691808767
Pull Request resolved: #8863
@swolchok swolchok added the release notes: ops & kernels Changes to the opset and any new / changed kernel implementations label Mar 3, 2025
@swolchok swolchok requested a review from kimishpatel March 3, 2025 23:46
@swolchok swolchok force-pushed the gh/swolchok/299/head branch from 7cbe7a1 to 7bc4529 Compare March 4, 2025 00:28
@swolchok
Copy link
Contributor Author

swolchok commented Mar 4, 2025

ping @manuelcandales @kimishpatel

[ghstack-poisoned]
@swolchok swolchok force-pushed the gh/swolchok/299/head branch from 7bc4529 to 764977b Compare March 4, 2025 16:11
@swolchok
Copy link
Contributor Author

swolchok commented Mar 4, 2025

(just rebased the branch, but tests were all green right before)

swolchok added 3 commits March 4, 2025 09:43
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@swolchok swolchok merged commit 5814a3b into main Mar 4, 2025
49 of 50 checks passed
@swolchok swolchok deleted the gh/swolchok/299/head branch March 4, 2025 23:08
zonglinpeng pushed a commit that referenced this pull request Mar 6, 2025
We don't need a second isnan; see code comment. (This is a small optimization.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: ops & kernels Changes to the opset and any new / changed kernel implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants