Futures support with cross-tensor attribution 2/n #1547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D73466780 |
Summary: This diff just - Moves some logic into `_attribute_with_independent_feature_masks_future()` - Adds `enable_cross_tensor_attribution` as a parameter to `attribute_future()`. No functional change is expected from this diff. Differential Revision: D73464680
Summary: Copypasta, refactor in next diff Differential Revision: D73466780
sarahtranfb
force-pushed
the
export-D73466780
branch
from
7619498 to
516ba89
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73466780 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Copypasta, refactor in next diff
Differential Revision: D73466780