Skip to content

[q]LogProbabilityOfFeasibility #2815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SebastianAment
Copy link
Contributor

@SebastianAment SebastianAment commented Apr 9, 2025

Summary: This commit adds LogProbabilityOfFeasibility and the corresponding batch Monte-Carlo version qLogProbabilityOfFeasibility. These new acquisition functions compute a probability of feasibility acquisition value that is particularly relevant for optimization runs that start out without any feasible observations. After a feasible observation is found, the acquisition function likely becomes over-exploitative, and one is better served switching to an acquisition function that also takes into account the objective value, e.g. qLogNEI.

Differential Revision: D72411936

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Apr 9, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72411936

SebastianAment added a commit to SebastianAment/botorch that referenced this pull request Apr 9, 2025
Summary:

This commit adds `LogProbabilityOfFeasibility` and the corresponding batch Monte-Carlo version `qLogProbabilityOfFeasibility`. These new acquisition functions compute a probability of feasibility acquisition value that is particularly relevant for optimization runs that start out without any feasible observations. After a feasible observation is found, the acquisition function likely becomes over-exploitative, and one is better served switching to an acquisition function that also takes into account the objective value, e.g. `qLogNEI`.

Differential Revision: D72411936
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72411936

SebastianAment added a commit to SebastianAment/botorch that referenced this pull request Apr 9, 2025
Summary:

This commit adds `LogProbabilityOfFeasibility` and the corresponding batch Monte-Carlo version `qLogProbabilityOfFeasibility`. These new acquisition functions compute a probability of feasibility acquisition value that is particularly relevant for optimization runs that start out without any feasible observations. After a feasible observation is found, the acquisition function likely becomes over-exploitative, and one is better served switching to an acquisition function that also takes into account the objective value, e.g. `qLogNEI`.

Differential Revision: D72411936
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72411936

@jduerholt
Copy link
Collaborator

Hi @SebastianAment,

this looks very useful, especially in the case described above.

Just one question/remark: Will you also add the acqf to get_acquisition_function in factory.py? Or do you plan to deprecate this method in favor of the acqf constructors in the future? If yes, do you have some kind of documentation on how to use this constructors properly? Internally we are currently heavily relying on get_acquisition_function as it is a nice convenience function ;)

Best,

Johannes

SebastianAment added a commit to SebastianAment/botorch that referenced this pull request Apr 10, 2025
Summary:

This commit adds `LogProbabilityOfFeasibility` and the corresponding batch Monte-Carlo version `qLogProbabilityOfFeasibility`. These new acquisition functions compute a probability of feasibility acquisition value that is particularly relevant for optimization runs that start out without any feasible observations. After a feasible observation is found, the acquisition function likely becomes over-exploitative, and one is better served switching to an acquisition function that also takes into account the objective value, e.g. `qLogNEI`.

Differential Revision: D72411936
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72411936

@SebastianAment
Copy link
Contributor Author

Hi @jduerholt,

Good point! We haven't been using the helper much internally, I'll add it for convenience. :)

Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (cd36e52) to head (61e2664).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2815   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          206       206           
  Lines        18679     18713   +34     
=========================================
+ Hits         18679     18713   +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

SebastianAment added a commit to SebastianAment/botorch that referenced this pull request Apr 10, 2025
Summary:

This commit adds `LogProbabilityOfFeasibility` and the corresponding batch Monte-Carlo version `qLogProbabilityOfFeasibility`. These new acquisition functions compute a probability of feasibility acquisition value that is particularly relevant for optimization runs that start out without any feasible observations. After a feasible observation is found, the acquisition function likely becomes over-exploitative, and one is better served switching to an acquisition function that also takes into account the objective value, e.g. `qLogNEI`.

Differential Revision: D72411936
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72411936

SebastianAment added a commit to SebastianAment/botorch that referenced this pull request Apr 10, 2025
Summary:

This commit adds `LogProbabilityOfFeasibility` and the corresponding batch Monte-Carlo version `qLogProbabilityOfFeasibility`. These new acquisition functions compute a probability of feasibility acquisition value that is particularly relevant for optimization runs that start out without any feasible observations. After a feasible observation is found, the acquisition function likely becomes over-exploitative, and one is better served switching to an acquisition function that also takes into account the objective value, e.g. `qLogNEI`.

Differential Revision: D72411936
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72411936

SebastianAment added a commit to SebastianAment/botorch that referenced this pull request Apr 11, 2025
Summary:

This commit adds `LogProbabilityOfFeasibility` and the corresponding batch Monte-Carlo version `qLogProbabilityOfFeasibility`. These new acquisition functions compute a probability of feasibility acquisition value that is particularly relevant for optimization runs that start out without any feasible observations. After a feasible observation is found, the acquisition function likely becomes over-exploitative, and one is better served switching to an acquisition function that also takes into account the objective value, e.g. `qLogNEI`.

Differential Revision: D72411936
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72411936

SebastianAment added a commit to SebastianAment/botorch that referenced this pull request Apr 11, 2025
Summary:

This commit adds `LogProbabilityOfFeasibility` and the corresponding batch Monte-Carlo version `qLogProbabilityOfFeasibility`. These new acquisition functions compute a probability of feasibility acquisition value that is particularly relevant for optimization runs that start out without any feasible observations. After a feasible observation is found, the acquisition function likely becomes over-exploitative, and one is better served switching to an acquisition function that also takes into account the objective value, e.g. `qLogNEI`.

Differential Revision: D72411936
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72411936

Summary:

This commit adds `LogProbabilityOfFeasibility` and the corresponding batch Monte-Carlo version `qLogProbabilityOfFeasibility`. These new acquisition functions compute a probability of feasibility acquisition value that is particularly relevant for optimization runs that start out without any feasible observations. After a feasible observation is found, the acquisition function likely becomes over-exploitative, and one is better served switching to an acquisition function that also takes into account the objective value, e.g. `qLogNEI`.

Differential Revision: D72411936
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72411936

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants