Fix regression for user config files #18656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
sterliakov
reviewed
Feb 10, 2025
mypy/config_parser.py
Outdated
| @@ -276,7 +276,7 @@ def _find_config_file( | |||
| break | |||
| current_dir = parent_dir | |||
|
|
|||
| for config_file in defaults.USER_CONFIG_FILES: | |||
| for config_file in map(os.path.expanduser, defaults.USER_CONFIG_FILES): | |||
There was a problem hiding this comment.
Is there any reason to expand here and not early in defaults.py?
There was a problem hiding this comment.
Fair point, if the original code had done that the bug would never have happened :-)
|
Diff from mypy_primer, showing the effect of this PR on open source code: django-stubs (https://github.com./typeddjango/django-stubs): 1.97x faster (49.0s -> 24.9s in a single noisy sample)
|
ericmarkmartin
pushed a commit
to ericmarkmartin/mypy
that referenced
this pull request
Feb 19, 2025
Fixes python#18650 Slightly annoying to add a test for since it would clutter up user home directory
ericmarkmartin
pushed a commit
to ericmarkmartin/mypy
that referenced
this pull request
Feb 19, 2025
Fixes python#18650 Slightly annoying to add a test for since it would clutter up user home directory
x612skm
pushed a commit
to x612skm/mypy-dev
that referenced
this pull request
Feb 24, 2025
Fixes python#18650 Slightly annoying to add a test for since it would clutter up user home directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18650
Slightly annoying to add a test for since it would clutter up user home directory