Skip to content

Allow overriding unstruct_collection_overrides #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ericbn
Copy link
Contributor

@ericbn ericbn commented Apr 12, 2023

Fixes #350

@ericbn ericbn force-pushed the override_unstruct_collection_overrides branch from c125033 to 1ea99bc Compare April 12, 2023 21:05
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2023

Codecov Report

Merging #353 (aeed3d6) into main (5ccd616) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #353   +/-   ##
=======================================
  Coverage   97.47%   97.47%           
=======================================
  Files          20       20           
  Lines        1582     1582           
=======================================
  Hits         1542     1542           
  Misses         40       40           
Impacted Files Coverage Δ
src/cattrs/preconf/bson.py 100.00% <ø> (ø)
src/cattrs/preconf/cbor2.py 100.00% <ø> (ø)
src/cattrs/preconf/json.py 100.00% <ø> (ø)
src/cattrs/preconf/msgpack.py 100.00% <ø> (ø)
src/cattrs/preconf/orjson.py 100.00% <ø> (ø)
src/cattrs/preconf/pyyaml.py 100.00% <ø> (ø)
src/cattrs/preconf/tomlkit.py 100.00% <ø> (ø)
src/cattrs/preconf/ujson.py 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Tinche
Copy link
Member

Tinche commented Apr 14, 2023

Lgtm, just add a small changelog snippet and we're good to go. Thanks!

@ericbn
Copy link
Contributor Author

ericbn commented Apr 14, 2023

Cool, done!

@Tinche Tinche merged commit 6542feb into python-attrs:main Apr 14, 2023
@Tinche
Copy link
Member

Tinche commented Apr 14, 2023

Thanks!

@ericbn ericbn deleted the override_unstruct_collection_overrides branch April 14, 2023 16:54
@Tinche Tinche added this to the 23.1 milestone May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow overriding unstruct_collection_overrides in preconf make_converter
3 participants