Skip to content

Do not write .gitignore if already exists #1866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2020
Merged

Do not write .gitignore if already exists #1866

merged 1 commit into from
Jun 21, 2020

Conversation

gaborbernat
Copy link
Contributor

@gaborbernat gaborbernat commented Jun 21, 2020

This ensures that we do not overwrite an existing .gitignore when the
target directory is not created by virtualenv.

Resolves #1862.

This ensures that we do not overwrite an existing .gitignore when the
target directory is not created by virtualenv.

Signed-off-by: Bernat Gabor <[email protected]>
@codecov
Copy link

codecov bot commented Jun 21, 2020

Codecov Report

Merging #1866 into master will decrease coverage by 4.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1866      +/-   ##
==========================================
- Coverage   93.91%   89.71%   -4.21%     
==========================================
  Files          86       86              
  Lines        4159     4161       +2     
==========================================
- Hits         3906     3733     -173     
- Misses        253      428     +175     
Flag Coverage Δ
#tests 89.71% <100.00%> (-4.21%) ⬇️
Impacted Files Coverage Δ
src/virtualenv/create/creator.py 95.27% <100.00%> (-0.73%) ⬇️
src/virtualenv/util/subprocess/_win_subprocess.py 0.00% <0.00%> (-95.09%) ⬇️
src/virtualenv/util/path/_pathlib/via_os_path.py 0.00% <0.00%> (-91.35%) ⬇️
src/virtualenv/util/subprocess/__init__.py 88.88% <0.00%> (-11.12%) ⬇️
src/virtualenv/app_data/__init__.py 88.37% <0.00%> (-6.98%) ⬇️
src/virtualenv/util/path/_sync.py 86.20% <0.00%> (-6.90%) ⬇️
...ualenv/create/via_global_ref/builtin/pypy/pypy2.py 92.20% <0.00%> (-6.50%) ⬇️
...ualenv/create/via_global_ref/builtin/pypy/pypy3.py 94.87% <0.00%> (-5.13%) ⬇️
src/virtualenv/info.py 95.00% <0.00%> (-5.00%) ⬇️
src/virtualenv/util/path/_pathlib/__init__.py 37.50% <0.00%> (-4.17%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cd009b...8a3dc83. Read the comment docs.

@gaborbernat gaborbernat merged commit 86deb12 into pypa:master Jun 21, 2020
@gaborbernat gaborbernat deleted the 1862 branch June 21, 2020 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.gitignore added to places it should not
1 participant