-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix used-before-assignment
if conditional imports guarded again when used
#7980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix used-before-assignment
if conditional imports guarded again when used
#7980
Conversation
🤖 Effect of this PR on checked open source code: 🤖 Effect on music21:
Effect on pandas:
The following messages are no longer emitted:
This comment was generated for commit 386ffe2 |
Pull Request Test Coverage Report for Build 3772618211
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Elegant !
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-maintenance/2.15.x maintenance/2.15.x
# Navigate to the new working tree
cd .worktrees/backport-maintenance/2.15.x
# Create a new branch
git switch --create backport-7980-to-maintenance/2.15.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e6f0bc5d32965eef37e498e15f05914d4275afb5
# Push it to GitHub
git push --set-upstream origin backport-7980-to-maintenance/2.15.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-maintenance/2.15.x Then, create a pull request where the |
When the primer emits a new useless supression : feelsgood.jpg |
Type of Changes
Description
Closes #7979
See regression test; fixes false positive in
music21
.