Add support for reading from stdin #2746

twmr · 2019-02-13T21:21:07Z

First of all thx @cpitclaudel for starting with the first draft (#1189) of the Read-from-stdin feature.

This PR is based on the inital PR by @cpitclaudel and tries to incorporate the comment by @PCManticore from #1189. I would like to know from @PCManticore if this PR now goes into the right direction.

I tested this PR by using the following command:

cat examples/custom_raw.py | ./bin/pylint --from-stdin custom_raw.py

Closes: #1187

Steps

Add yourself to CONTRIBUTORS if you are a new contributor.
Add a ChangeLog entry describing what your PR does.
If it's a new feature or an important bug fix, add a What's New entry in doc/whatsnew/<current release.rst>.
Write a good description on what the PR does.

Description

Type of Changes

	Type
✓	🐛 Bug fix
✓	✨ New feature
✓	🔨 Refactoring
✓	📜 Docs

Related Issue

coveralls · 2019-02-13T22:49:35Z

Coverage decreased (-0.002%) to 89.65% when pulling 0e37eaa on thisch:readstdin into 946657c on PyCQA:master.

PCManticore · 2019-02-17T20:29:19Z

@Thisch This is very cool, thanks for working on it! Can you add some tests as well?

twmr · 2019-02-18T17:02:35Z

pylint/lint.py

+def _read_stdin():
+    # https://mail.python.org/pipermail/python-list/2012-November/634424.html
+    # FIXME should this try to check the file's declared encoding?
+    sys.stdin = TextIOWrapper(sys.stdin.detach(), newline=None)


I don't yet understand why we need this line.

This probably helps: https://stackoverflow.com/questions/31488419/binary-input-with-an-ascii-text-header-read-from-stdin

twmr · 2019-02-19T19:44:40Z

I need a bit your help with fixing the unit tests:

Here are the errors reported by travis ci:

3.4:
AssertionError: assert '************* Module mymodule\nmymodule.py:1:0: W0611: Unused import os (unused-import)' in
                       '************* Module mymodule\nmymodule.py:1:0: C0304: Final newline missing (missing-final-newline)\n************* M...0611: Unused import os (unused-import)\n\n-------------------------------------\nYour code has been rated at -20.00/10'
3.5-dev:
	
AssertionError: assert '************* Module mymodule\nmymodule.py:1:0: W0611: Unused import os (unused-import)' in 
                       '************* Module mymodule\nmymodule.py:1:0: C0304: Final newline missing (missing-final-newline)\n************* M...0611: Unused import os (unused-import)\n\n-------------------------------------\nYour code has been rated at -20.00/10'

3.6:
AssertionError: assert '************* Module mymodule\nmymodule.py:1:0: W0611: Unused import os (unused-import)' in 
                       '************* Module mymodule\nmymodule.py:1:0: C0304: Final newline missing (missing-final-newline)\n************* M...0611: Unused import os (unused-import)\n\n-------------------------------------\nYour code has been rated at -20.00/10'

3.7:
AssertionError: assert '************* Module mymodule\nmymodule.py:1:0: W0611: Unused import os (unused-import)' in 
                       '************* Module mymodule\nmymodule.py:1:0: C0304: Final newline missing (missing-final-newline)\n************* M...0611: Unused import os (unused-import)\n\n-------------------------------------\nYour code has been rated at -20.00/10'

Where does this "M...0611" output come from? When I run pylint on a file with the contents "import os" locally, pylint reports

************* Module mymodule
mymodule.py:1:0: C0111: Missing module docstring (missing-docstring)
mymodule.py:1:0: W0611: Unused import os (unused-import)

----------------------------------------------------------------------
Your code has been rated at -10.00/10 (previous run: -10.00/10, +0.00)

I don't understand why the travis-ci output contains "M...0611" whereas locally I get "W0611".

cpitclaudel · 2019-02-19T22:36:02Z

CONTRIBUTORS.txt

@@ -269,3 +269,5 @@ contributors:
 * Svetoslav Neykov: contributor

 * Federico Bond: contributor
+
+* Thomas Hisch: contributor


If you patch is based on the one in #1189, please acknowledge that here too :)

Sure. Thx for pointing that out.

cpitclaudel · 2019-02-19T22:36:42Z

Thanks for working on this! I don't have time to review the patch, but I'm excited to see that this feature will be coming soon ^^

PCManticore

Hey @Thisch Took a first look and this is going in the right direction, thanks for the work! I'm not sure yet why it fails on Travis, as I didn't get a chance to see the failure itself. Once the new job fails again, I'll check again.

pylint/lint.py

pylint/test/test_self.py

twmr · 2019-02-21T11:42:47Z

I need a bit your help with fixing the unit tests:

Here are the errors reported by travis ci:

3.4:
AssertionError: assert '************* Module mymodule\nmymodule.py:1:0: W0611: Unused import os (unused-import)' in
                       '************* Module mymodule\nmymodule.py:1:0: C0304: Final newline missing (missing-final-newline)\n************* M...0611: Unused import os (unused-import)\n\n-------------------------------------\nYour code has been rated at -20.00/10'
3.5-dev:
	
AssertionError: assert '************* Module mymodule\nmymodule.py:1:0: W0611: Unused import os (unused-import)' in 
                       '************* Module mymodule\nmymodule.py:1:0: C0304: Final newline missing (missing-final-newline)\n************* M...0611: Unused import os (unused-import)\n\n-------------------------------------\nYour code has been rated at -20.00/10'

3.6:
AssertionError: assert '************* Module mymodule\nmymodule.py:1:0: W0611: Unused import os (unused-import)' in 
                       '************* Module mymodule\nmymodule.py:1:0: C0304: Final newline missing (missing-final-newline)\n************* M...0611: Unused import os (unused-import)\n\n-------------------------------------\nYour code has been rated at -20.00/10'

3.7:
AssertionError: assert '************* Module mymodule\nmymodule.py:1:0: W0611: Unused import os (unused-import)' in 
                       '************* Module mymodule\nmymodule.py:1:0: C0304: Final newline missing (missing-final-newline)\n************* M...0611: Unused import os (unused-import)\n\n-------------------------------------\nYour code has been rated at -20.00/10'

Where does this "M...0611" output come from? When I run pylint on a file with the contents "import os" locally, pylint reports

************* Module mymodule
mymodule.py:1:0: C0111: Missing module docstring (missing-docstring)
mymodule.py:1:0: W0611: Unused import os (unused-import)

----------------------------------------------------------------------
Your code has been rated at -10.00/10 (previous run: -10.00/10, +0.00)

I don't understand why the travis-ci output contains "M...0611" whereas locally I get "W0611".

The "M...0611" output is generated by the pytest, so it is not related to an issue in pylint.

twmr · 2019-02-22T19:40:04Z

@PCManticore when you have time, please take again a look at this PR. I think that it is ready now.

In the course of adding the testcase a related bug in the --from-stdin code was fixed.

PCManticore

Hey @Thisch Great stuff! Left a final round of comments, once these are addresses we can merge the PR.

pylint/lint.py

pylint/test/test_self.py

pylint/lint.py

PCManticore · 2019-02-27T07:43:12Z

pylint/lint.py

+            if ast_node is not None:
+                self.file_state = utils.FileState(filepath)
+                self.check_astroid_module(ast_node, walker, rawcheckers, tokencheckers)
+                # warn about spurious inline messages handling


This block seems duplicated with the normal flow, maybe move it after the whole if branch?

Moving it after the whole if self.config.from_stdin branch does not work IMO. I think it is not worth the effort to avoid this code duplication, especially since only a couple of lines of code are duplicated.

twmr · 2019-02-27T19:24:45Z

the failure on travis-ci is unrelated to my change.

PCManticore · 2019-03-02T13:28:55Z

Thank you @Thisch for your contribution! 🎉 This will be part of pylint 2.4. when it gets released.

twmr · 2019-06-19T17:27:31Z

@PCManticore Any estimates when we can expect a 2.4 release? What are the open issues that need to be fixed before 2.4 can be relased?

PCManticore · 2019-06-20T07:35:56Z

@Thisch It's going to happen most likely in July. A main blocker is having Python 3.8 support. A separate one is that I'd like to have #2036 in time for 2.4 release, but if that won't happen in due time, we can release without it.

twmr changed the title ~~Add support for reading from stdin~~ WIP Add support for reading from stdin Feb 15, 2019

twmr force-pushed the readstdin branch from 485f410 to b8f3e37 Compare February 15, 2019 18:59

twmr mentioned this pull request Feb 15, 2019

Add pylint support. palantir/python-language-server#385

Merged

twmr force-pushed the readstdin branch 2 times, most recently from d414dc4 to e96d49d Compare February 18, 2019 17:01

twmr commented Feb 18, 2019

View reviewed changes

twmr force-pushed the readstdin branch from e96d49d to b2e8104 Compare February 18, 2019 17:09

twmr changed the title ~~WIP Add support for reading from stdin~~ Add support for reading from stdin Feb 18, 2019

twmr force-pushed the readstdin branch 3 times, most recently from 580a862 to 7a967be Compare February 18, 2019 21:13

cpitclaudel reviewed Feb 19, 2019

View reviewed changes

twmr force-pushed the readstdin branch from 7a967be to a11aecf Compare February 20, 2019 07:42

PCManticore reviewed Feb 20, 2019

View reviewed changes

pylint/lint.py Outdated Show resolved Hide resolved

pylint/lint.py Outdated Show resolved Hide resolved

pylint/test/test_self.py Outdated Show resolved Hide resolved

twmr force-pushed the readstdin branch 5 times, most recently from 4890940 to 564105d Compare February 21, 2019 10:27

twmr force-pushed the readstdin branch 4 times, most recently from ae1a11e to 718843f Compare February 22, 2019 19:29

Add support for reading from stdin

30dfb90

Add testcase for relimports with --from-stdin

9112920

In the course of adding the testcase a related bug in the --from-stdin code was fixed.

twmr force-pushed the readstdin branch from 718843f to 9112920 Compare February 23, 2019 20:10

twmr mentioned this pull request Feb 26, 2019

pylint: Add support for standard-input t (requires pylint 2.5) flycheck/flycheck#1546

Open

PCManticore approved these changes Feb 27, 2019

View reviewed changes

Incorporate review comment

ff0e26a

Merge branch 'master' into readstdin

0e37eaa

PCManticore merged commit fb5a2a6 into pylint-dev:master Mar 2, 2019

hippo91 mentioned this pull request Mar 30, 2019

False-positive E1137 (unsupported-assignment-operation) with np.empty_like #2767

Closed

cbosoft mentioned this pull request May 21, 2019

Pylint from stdin and on-the-fly python linting dense-analysis/ale#2522

Closed

twmr deleted the readstdin branch June 7, 2019 20:22

cpitclaudel mentioned this pull request May 8, 2020

pylint false positive attempted relative import beyond top-level package flycheck/flycheck#1758

Closed

9 tasks

pedroqueiroga mentioned this pull request May 8, 2020

pylint vs epylint for editor usage #3606

Closed

oliverwiegers mentioned this pull request Jun 11, 2020

Enable asyncronous linting for pylint dense-analysis/ale#3204

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for reading from stdin #2746

Add support for reading from stdin #2746

twmr commented Feb 13, 2019 •

edited

Loading

coveralls commented Feb 13, 2019 •

edited

Loading

PCManticore commented Feb 17, 2019

twmr Feb 18, 2019

twmr Feb 18, 2019

twmr commented Feb 19, 2019

cpitclaudel Feb 19, 2019

twmr Feb 20, 2019

cpitclaudel commented Feb 19, 2019

PCManticore left a comment

twmr commented Feb 21, 2019

twmr commented Feb 22, 2019

PCManticore left a comment

PCManticore Feb 27, 2019

twmr Feb 27, 2019 •

edited

Loading

twmr commented Feb 27, 2019

PCManticore commented Mar 2, 2019

twmr commented Jun 19, 2019

PCManticore commented Jun 20, 2019

Add support for reading from stdin #2746

Add support for reading from stdin #2746

Conversation

twmr commented Feb 13, 2019 • edited Loading

Steps

Description

Type of Changes

Related Issue

coveralls commented Feb 13, 2019 • edited Loading

PCManticore commented Feb 17, 2019

twmr Feb 18, 2019

Choose a reason for hiding this comment

twmr Feb 18, 2019

Choose a reason for hiding this comment

twmr commented Feb 19, 2019

cpitclaudel Feb 19, 2019

Choose a reason for hiding this comment

twmr Feb 20, 2019

Choose a reason for hiding this comment

cpitclaudel commented Feb 19, 2019

PCManticore left a comment

Choose a reason for hiding this comment

twmr commented Feb 21, 2019

twmr commented Feb 22, 2019

PCManticore left a comment

Choose a reason for hiding this comment

PCManticore Feb 27, 2019

Choose a reason for hiding this comment

twmr Feb 27, 2019 • edited Loading

Choose a reason for hiding this comment

twmr commented Feb 27, 2019

PCManticore commented Mar 2, 2019

twmr commented Jun 19, 2019

PCManticore commented Jun 20, 2019

twmr commented Feb 13, 2019 •

edited

Loading

coveralls commented Feb 13, 2019 •

edited

Loading

twmr Feb 27, 2019 •

edited

Loading