BUG: Added new names for pandas isna/notna unary functions #1664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In pandas commit pandas-dev/pandas@7930202 isna and notna were added as aliases for isnull and notnull. Those need to be added to PANDAS_UNARY_FUNCTIONS for xarray datasets notnull to work. Closes pydata#1663.
|
I am happy to add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pandas commit
pandas-dev/pandas@7930202
isna and notna were added as aliases for isnull and notnull. Those need
to be added to PANDAS_UNARY_FUNCTIONS for xarray datasets notnull to work.
Closes #1663.
Note: I'm not sure how to test for this, as I think existing tests should be already failing due to this. In fact, when I run
nosetestson my system I get 123 skips, 29 errors and 2 failures, none of which are related to my addition, so there must be something wrong on my system.I did not try the flake8 test and I think new documentation is exaggerated in this case.