SpawnSyncOptions docs: reduce supported input types to Buffer
#64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi-Angel
changed the title
input types to stringinput types to Buffer
The option only supports `Maybe Buffer` and providing anything else like `Maybe String` will result in compilation error.
Hi-Angel
changed the title
input types to Bufferinput types to Buffer
|
Thanks! I'll add a changelog entry for this when I update it for the new version release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
inputonly supportsMaybe Bufferand providing anything else likeMaybe Stringwill result in compilation error.I had a problem due to this misdocumentation, where I provided a string and it ofc didn't compile. So figured would be good to have this fixed.
Checklist: