fix(typescript): add types for createLambdaFunction()
#132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds types for Lambda function URLs. Details about Lambda function URLs can be found below: - https://aws.amazon.com/blogs/aws/announcing-aws-lambda-function-urls-built-in-https-endpoints-for-single-function-microservices/ - https://docs.aws.amazon.com/lambda/latest/dg/urls-configuration.html No changes should be necessary to the `createLambdaFunction` implementation since the expected arguments and return types are nearly identical.
|
@gr2m, can this PR be merged? |
gr2m
changed the title
createLambdaFunction()
gr2m
approved these changes
Jan 30, 2025
|
Thanks AJ! |
|
🎉 This PR is included in version 4.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ajschmidt8
added a commit
to ajschmidt8/adapter-aws-lambda-serverless
that referenced
this pull request
Jan 30, 2025
This PR fixes the types that were introduced in probot#132. Sorry for the noise!
gr2m
pushed a commit
that referenced
this pull request
Feb 6, 2025
This PR fixes the types that were introduced in #132. Sorry for the noise!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds types for Lambda function URLs.
Details about Lambda function URLs can be found below:
No changes should be necessary to the
createLambdaFunctionimplementation since the expected arguments and return types are nearly identical.