Skip to content

feat(settings): add new system component #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 4, 2020
Merged

feat(settings): add new system component #367

merged 4 commits into from
Feb 4, 2020

Conversation

jasonkuhrt
Copy link
Member

@jasonkuhrt jasonkuhrt commented Feb 4, 2020 •
edited
Loading

closes #297

BREAKING CHANGE:

  • Settings that used to be passed to server.start are now under server key in settings input.

  • log.settings no longer exists. Settings that used to be passed to it are now under logger key in settings input.

  • schema.settings no longer exists. Settings that used to be passed to it are now under schema key in settings input.

TODO

  • docs
  • tests

@jasonkuhrt jasonkuhrt requested a review from Weakky February 4, 2020 03:13
@jasonkuhrt jasonkuhrt marked this pull request as ready for review February 4, 2020 03:13
@jasonkuhrt jasonkuhrt self-assigned this Feb 4, 2020
@jasonkuhrt jasonkuhrt added note/breaking-change This issue existed already scope/settings type/feat Add a new capability or enhance an existing one labels Feb 4, 2020
@jasonkuhrt jasonkuhrt changed the title feat(configurator): add new system component feat(settings): add new system component Feb 4, 2020
@jasonkuhrt jasonkuhrt merged commit 7474d3d into master Feb 4, 2020
@jasonkuhrt jasonkuhrt deleted the feat/297/settings-system branch February 4, 2020 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Weakky Weakky Awaiting requested review from Weakky

Assignees

@jasonkuhrt jasonkuhrt

Labels
note/breaking-change This issue existed already scope/settings type/feat Add a new capability or enhance an existing one
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configuration System
1 participant
@jasonkuhrt