Add database shape #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Can you please resolve the conflicts and also remove the shadow? |
Add the ability to use the PlantUML `database` shape for systems (including external systems), containers, and components. The following macros have been added: - `SystemDb` - `SystemDb_Ext` - `ContainerDb` - `ComponentDb` These macros take the same parameters as their regular counterparts.
coldacid
force-pushed
the
feature/databases
branch
from
81bad30 to
3d58d2d
Compare
|
I've rebased the branch to eliminate the merge conflict, and turned off shadows for the database elements. I also added the database macros to the lists in the readme file since I noticed that I had forgotten to add them there. Should be good to merge now! |
|
Big thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @thorsil's PR #2 but based on the current styling and structure. Merging this should obsolete #2.
For additional shapes, I wouldn't have any suggestions that would work with PlantUML at this time. I'd love to have a folder shape for file system elements, but the actual
foldershape in PlantUML sticks the label in the label space of the folder icon instead of in the main box. Unless PlantUML starts providing the ability to add custom shapes instead of just sprites, adding the database shape is about all we can do.