-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add support for lineThickness in AddRelTag #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
994005e
to
2925afe
Compare
2925afe
to
2e49911
Compare
Hi @fredde-fisk, thank you for the new skinparam based implementation. Your solution uses the I have only 2 questions: Thank you and best regards
I checked the last non working sample too (and it is working with current version, I didn't check it with an older version)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I commented it ~50 days ago but it was not visible for you.
I hope it is visible now.
Can you change the argument order?
@@ -550,7 +553,7 @@ $elementSkin | |||
!return $tagEntry | |||
!endfunction | |||
|
|||
!function $tagRelLegendEntry($tagStereo, $textColor, $lineColor, $lineStyle, $legendText, $legendSprite) | |||
!function $tagRelLegendEntry($tagStereo, $textColor, $lineColor, $lineStyle, $lineThickness, $legendText, $legendSprite) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$lineThickness
should be last argument in all calls, that existing diagrams have no unexpected side effects if they use unnamed arguments
Hi @fredde-fisk, |
New attempt at #218