-
Notifications
You must be signed in to change notification settings - Fork 1.1k
#149 Calculate missing legend colors based on brightness #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Potherca
merged 12 commits into
plantuml-stdlib:master
from
kirchsth:feature/149_LegendColor
Jul 4, 2021
Merged
#149 Calculate missing legend colors based on brightness #150
Potherca
merged 12 commits into
plantuml-stdlib:master
from
kirchsth:feature/149_LegendColor
Jul 4, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nIconic and tags (7 - update sample with scaled sprites) plantuml-stdlib#49, plantuml-stdlib#139: Persons can be displayed as portraits - SHOW_PERSON_PORTRAIT()
…._DOWN(), ..._LEFT(), ..._RIGHT()
…() and Lay_Distance() (instead of SHOW_LEGEND_UP(), ..._DOWN(), ..._LEFT(), ..._RIGHT())
…() and Lay_Distance() (2 - fix https://)
…() and Lay_Distance() (3 - legend is reserved; LEGEND() is new default alias)
…antUML version workaround)
Potherca
approved these changes
Jun 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
%is_dark()
the missing legend color can be calculated with better contrast (e.g. dark text colors get automatically a light background color if no background color is defined).It can be tested via my extended branch.
techn. details: the PlantUML server has some caching problems with included files. If you test/use it with already rendered files on the PlantUML server please add e.g. a space to the diagram that a new version is calculated. (@Potherca: I hope it will be fixed in the meantime, otherwise please add a space to the 2 diagrams in the master branch too, ~30 min after the first merge)
BR Helmut
used source