Skip to content

Microservice container #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sudsk opened this issue Feb 24, 2019 · 7 comments · Fixed by #147
Closed

Microservice container #12

sudsk opened this issue Feb 24, 2019 · 7 comments · Fixed by #147
Milestone

Comments

@sudsk
Copy link

sudsk commented Feb 24, 2019

Thanks for the great work. I would like to use hexagon for microservice container instead of rectangle. Where should I add this additional container type?

@adrianvlupu
Copy link
Member

Hi,

You can define new container types right after you include the C4_Container.puml, similar to how the ContainerDb type was created.

@startuml
!includeurl https://raw.githubusercontent.com/RicardoNiepel/C4-PlantUML/master/C4_Container.puml

skinparam database<<container>> {
    StereotypeFontColor ELEMENT_FONT_COLOR
    FontColor ELEMENT_FONT_COLOR
    BackgroundColor CONTAINER_BG_COLOR
    BorderColor #3C7FC0
}
!define ContainerDb(e_alias, e_label, e_techn) database "==e_label\n//<size:TECHN_FONT_SIZE>[e_techn]</size>//" <<container>> as e_alias
!define ContainerDb(e_alias, e_label, e_techn, e_descr) database "==e_label\n//<size:TECHN_FONT_SIZE>[e_techn]</size>//\n\n e_descr" <<container>> as e_alias

ContainerDb(db1,"DB1", "SQL")

@enduml

But from what I know about plantUML you can't use the hexagon shape like you use the rectangle

rectangle Something
hexagon Other

This won't work.

@heshuhua
Copy link

I have the same question, any suggestion? thx.

@Potherca
Copy link
Member

There is a feature request to add a hexagon shape: https://forum.plantuml.net/10418/please-provide-a-hexagon-shape

I would suggest upvoting that.

adrianvlupu added a commit that referenced this issue Nov 28, 2020
Merged from plantuml-stdlib/C4-PlantUML/master
@aheil
Copy link
Member

aheil commented Nov 29, 2020

Adding such a shape will add in excess try complexity to the diagrams. In my opinion, I does not fully fit as a container neither as a component in terms of the C4 model. It probably makes more sense to create dedicated microservice diagrams in addition to your C4 diagrams.

@stale stale bot added the wontfix This will not be worked on label Jan 28, 2021
@stale stale bot added the stale Issue has not been active for 60 days label Mar 29, 2021
@stale stale bot closed this as completed Apr 5, 2021
@Potherca
Copy link
Member

Potherca commented Apr 30, 2021

The hexagon shape has been implemented in PlantUML:

Support in C4-PlantUML might be coming with #145

@Potherca Potherca removed wontfix This will not be worked on stale Issue has not been active for 60 days labels May 2, 2021
@Potherca Potherca reopened this May 2, 2021
@Potherca Potherca added this to the v2.3.0 milestone May 2, 2021
@Potherca
Copy link
Member

Potherca commented May 2, 2021

Reopening as this is under consideration in #145 .

@stale stale bot added the stale Issue has not been active for 60 days label Jul 1, 2021
@plantuml-stdlib plantuml-stdlib deleted a comment from stale bot Jul 2, 2021
@stale stale bot removed the stale Issue has not been active for 60 days label Jul 2, 2021
@plantuml-stdlib plantuml-stdlib deleted a comment from stale bot Jul 2, 2021
@plantuml-stdlib plantuml-stdlib deleted a comment from stale bot Jul 2, 2021
@Potherca
Copy link
Member

Potherca commented Jul 2, 2021

FYI: #146 also adds a eight-sided shape that can be used to represent a microservice.

@Potherca Potherca moved this to Todo in All Projects Jul 3, 2022
@Potherca Potherca moved this from Todo to Done in All Projects Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
5 participants