Fixed error message if no artifact found #2034
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YohDeadfall
force-pushed
the
fix-err-msg
branch
from
4eca177 to
c82e361
Compare
eeeebbbbrrrr
requested changes
Apr 12, 2025
cargo-pgrx/src/command/install.rs
Outdated
Comment on lines
423
to
425
| // cargo sometimes decides to change whether targets are kebab-case or snake_case in metadata, | ||
| // so normalize away the difference | ||
| let target_name = manifest.target_name()?.replace('-', "_"); |
There was a problem hiding this comment.
What's the reason for removing line 425 but not also updating the comment? Now I don't know what the intent is supposed to be.
There was a problem hiding this comment.
Removed it as it's useless now according to the selected logic.
|
Going to hold this until after v0.14.0 is released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.