Skip to content

PMM-11274 Added 'rdsadmin' database to ignored list #1589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 2, 2023

Conversation

tshcherban
Copy link
Contributor

@tshcherban tshcherban commented Jan 19, 2023

PMM-11274

Build: SUBMODULES-3015

Ignore rdsadmin database to avoid errors spamming logs. Thats a requirement from postgres_exporter.

@tshcherban tshcherban requested a review from a team as a code owner January 19, 2023 10:11
@tshcherban tshcherban requested review from recharte and JiriCtvrtka and removed request for a team January 19, 2023 10:11
@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #1589 (19446f2) into main (990740d) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 19446f2 differs from pull request most recent head 87d03d6. Consider uploading reports for the commit 87d03d6 to get more accurate results

@@            Coverage Diff             @@
##             main    #1589      +/-   ##
==========================================
- Coverage   43.43%   43.42%   -0.02%     
==========================================
  Files         372      371       -1     
  Lines       44073    44053      -20     
==========================================
- Hits        19145    19131      -14     
+ Misses      23175    23173       -2     
+ Partials     1753     1749       -4     
Flag Coverage Δ
managed 45.04% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
managed/services/agents/postgresql.go 62.19% <100.00%> (ø)
agent/runner/jobs/mongodb_backup_job.go 11.48% <0.00%> (-8.31%) ⬇️
managed/models/job_helpers.go 76.57% <0.00%> (-1.21%) ⬇️
managed/services/agents/jobs.go 0.00% <0.00%> (ø)
agent/runner/jobs/mongodb_restore_job.go 0.00% <0.00%> (ø)
agent/runner/jobs/pbm_job_logger.go
...aged/services/management/backup/backups_service.go 51.91% <0.00%> (+0.13%) ⬆️
...ged/services/management/dbaas/kubernetes_server.go 58.81% <0.00%> (+0.59%) ⬆️
managed/models/kubernetes_helpers.go 70.51% <0.00%> (+3.84%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tshcherban tshcherban merged commit 19ee12b into main Feb 2, 2023
@tshcherban tshcherban deleted the PMM-11274-rdsadmin-db-ignore branch February 2, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants