Skip to content

chore: update createOrder callback comment and example payload #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

gregjopa
Copy link
Contributor

@gregjopa gregjopa commented Jan 31, 2023

This PR updates the createOrder() callback comment to better describe what safe order information we should pass from the browser to the server.

@gregjopa gregjopa requested a review from westeezy January 31, 2023 22:51
Copy link

@westeezy westeezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@westeezy westeezy requested a review from sioked January 31, 2023 23:27
@gregjopa gregjopa merged commit 55a452b into main Feb 1, 2023
@gregjopa gregjopa deleted the update-create-order-strategy branch February 1, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants