Skip to content

fix main lint failure #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2024
Merged

fix main lint failure #129

merged 1 commit into from
Apr 12, 2024

Conversation

jshawl
Copy link
Contributor

@jshawl jshawl commented Apr 12, 2024

This PR fixes a lint failure on the main branch.

npx eslint now uses 9.0.0, which deprecated the --env argument unless using the legacy eslintrc mode:

I added --no-config-lookup to address the lookup error:

$ npx eslint

Oops! Something went wrong! :(

ESLint: 9.0.0

Error: Could not find config file.
    at locateConfigFileToUse (node_modules/eslint/lib/eslint/eslint.js:349:21)

I also increased the find -maxdepth value to include advanced-integration/v1 and advanced-integration/v1

@jshawl jshawl marked this pull request as ready for review April 12, 2024 12:04
@jshawl jshawl requested review from gregjopa and NavinPayPal April 12, 2024 12:04
Copy link
Contributor

@gregjopa gregjopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @jshawl! It's great to learn about how this is done in eslint 9.

💯

@gregjopa gregjopa merged commit bd8f509 into main Apr 12, 2024
2 checks passed
Copy link

@Cinderella252 Cinderella252 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eslint-plugin-jsdoc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants