Skip to content

Update indexing.rst #7188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2014
Merged

Conversation

AllenDowney
Copy link
Contributor

Adding a warning, and example, about using attribute access to create a new column.

Adding a warning, and example, about using attribute access to create a new column.
@AllenDowney
Copy link
Contributor Author

This pertains to Issue #7175

@@ -206,15 +206,19 @@ as an attribute:
dfa.A
panel.one

Setting is allowed as well
You can use attribute access to modify an existing element of a Series or column of a DataFrame, but be careful;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe move these couple of lines to an actual .. warning:: see below

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered that but thought this was enough of a gotcha that I wanted to
keep the warning right there with the problematic example.

But I am willing to be overruled.

On Tue, May 20, 2014 at 3:01 PM, jreback [email protected] wrote:

In doc/source/indexing.rst:

@@ -206,15 +206,19 @@ as an attribute:
dfa.A
panel.one

-Setting is allowed as well
+You can use attribute access to modify an existing element of a Series or column of a DataFrame, but be careful;

maybe move these couple of lines to an actual .. warning:: see below


Reply to this email directly or view it on GitHubhttps://github.com.//pull/7188/files#r12861818
.

@jreback
Copy link
Contributor

jreback commented May 20, 2014

ok...fine then...

@jorisvandenbossche ?

@jorisvandenbossche
Copy link
Member

Looking good. Thanks!

jorisvandenbossche added a commit that referenced this pull request May 20, 2014
@jorisvandenbossche jorisvandenbossche merged commit be45e0d into pandas-dev:master May 20, 2014
@AllenDowney AllenDowney deleted the patch-1 branch September 24, 2022 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants