The pool pointer is now available for ngx_http_modsecurity_config_cleanup #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems that this PR is also reasonable for owasp-modsecurity/ModSecurity#1546 |
zimmerle
reviewed
Mar 26, 2018
| @@ -649,7 +650,7 @@ ngx_http_modsecurity_config_cleanup(void *data) | |||
|
|
|||
| dd("deleting a loc conf -- RuleSet is: \"%p\"", t->rules_set); | |||
|
|
|||
| old_pool = ngx_http_modsecurity_pcre_malloc_init(NULL); | |||
| old_pool = ngx_http_modsecurity_pcre_malloc_init(t->pool); | |||
There was a problem hiding this comment.
Regardless the parameter here I guess the end result will be the same.
There was a problem hiding this comment.
oh wait, i think i've get your point. let me discuss with @defanator.
AirisX
force-pushed
the
fix/conf_cleanup_pool
branch
from
7efd4f0 to
c6ea19d
Compare
|
@defanator @zimmerle I did a rebase to apply patch more cleanly. |
zimmerle
pushed a commit
that referenced
this pull request
May 3, 2018
|
Merged! Thanks! |
pracj3am
pushed a commit
to cdn77/ModSecurity-nginx
that referenced
this pull request
Nov 4, 2022
pracj3am
added a commit
to cdn77/ModSecurity-nginx
that referenced
this pull request
Oct 10, 2023
pracj3am
added a commit
to cdn77/ModSecurity-nginx
that referenced
this pull request
Oct 10, 2023
pracj3am
added a commit
to cdn77/ModSecurity-nginx
that referenced
this pull request
Oct 10, 2023
pracj3am
added a commit
to cdn77/ModSecurity-nginx
that referenced
this pull request
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a little research and found out that the rules that are initialized in the pool by the
msc_rules_add_fileormsc_rules_addcan not be freed by themsc_rules_cleanupbecausengx_http_modsecurity_config_cleanupdoes not know anything about this pool (since it is NULL).