This repository was archived by the owner on Aug 7, 2020. It is now read-only.
feat(oui-inline-adder): add inline-adder component #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor(oui-inline-adder): component improvements
AxelPeter
requested review from
euhmeuh,
FredericEspiau and
JeremyDec
as code owners
This was referenced Oct 31, 2018
JeremyDec
approved these changes
Nov 2, 2018
antleblanc
reviewed
Nov 3, 2018
| <oui-field label="Field 2" size="m"> | ||
| <label class="oui-select"> | ||
| <select name="field2" ng-model="field2" class="oui-select__input" required> | ||
| <option value="" disabled selected>Select the OS</option> |
There was a problem hiding this comment.
Suggested change
| <option value="" disabled selected>Select the OS</option> | |
| <option value="" disabled selected>Select the Operating System</option> |
| <select name="field2" ng-model="field2" class="oui-select__input" required> | ||
| <option value="" disabled selected>Select the OS</option> | ||
| <option value="freebsd">FreeBSD</option> | ||
| <option value="linux">Linux</option> |
There was a problem hiding this comment.
As you may know, Linux is not an operating system. You probably mean a GNU/Linux distributions right? :)
There was a problem hiding this comment.
I'll update the example. It comes from the past contribution.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UK-16
Related to
ovh/ovh-ui-kit#302
ovh-ux/ovh-ui-kit-documentation#168