This repository was archived by the owner on Aug 7, 2020. It is now read-only.
feat(oui-page-header): create page-header component #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfougier
changed the title
This was referenced Jun 12, 2018
AxelPeter
suggested changes
Jun 13, 2018
packages/oui-page-header/README.md
Outdated
|
|
||
| | Attribute | Type | Binding | One-time Binding | Values | Default | Description | | ||
| | ---- | ---- | ---- | ---- | ---- | ---- | ---- | | ||
| | title | string | @? | true | | | title of the header | |
There was a problem hiding this comment.
What do you think about heading to avoid the attribute title behaviour.
packages/oui-page-header/README.md
Outdated
| | Attribute | Type | Binding | One-time Binding | Values | Default | Description | | ||
| | ---- | ---- | ---- | ---- | ---- | ---- | ---- | | ||
| | title | string | @? | true | | | title of the header | | ||
| | subtitle | string | @? | true | | | subtitle of the header | |
AxelPeter
reviewed
Jun 13, 2018
| <h2 class="oui-page-header__subtitle" | ||
| ng-if="::!!$ctrl.subtitle">{{::$ctrl.subtitle}}</h2> | ||
| </div> | ||
| <div ng-if="$ctrl.transcludeGuide" |
There was a problem hiding this comment.
Maybe we should add a class on these DIVs ?
whispyy
force-pushed
the
feat/page-header
branch
from
9356464 to
fb3d289
Compare
whispyy
force-pushed
the
feat/page-header
branch
from
fb3d289 to
3731db6
Compare
|
all corrected following to the new decisions |
neolitec
pushed a commit
that referenced
this pull request
Jun 21, 2018
* feat(oui-page-header): create component * feat(oui-page-header): add test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/#!/oui-angular/page-header@ovh_ui_kit_documentation-feat_page_header_stagingLinked to
ovh/ovh-ui-kit#219
ovh-ux/ovh-ui-kit-documentation#119