feat: add get_subnet_owner_hotkey method to Subtensor #2815

gap-editor · 2025-04-11T11:06:04Z

This pull request introduces a new public method, get_subnet_owner_hotkey, to the Subtensor class located in bittensor/core/subtensor.py.

Motivation:

Currently, retrieving the hotkey of a subnet owner requires using the lower-level query_subtensor method directly, like so:

# Example of current approach
owner_hotkey = subtensor.query_subtensor("SubnetOwnerHotkey", params=[netuid])

This PR aims to provide a more convenient and explicit high-level interface for this common query, enhancing the usability of the SDK for developers.

Implementation Details:

New Method: Added get_subnet_owner_hotkey(self, netuid: int, block: Optional[int] = None) -> Optional[str] to the Subtensor class.
Functionality:
- Accepts the netuid (subnet unique identifier) and an optional block number.
- Performs an initial check using self.subnet_exists(netuid, block=block) to ensure the target subnet is valid before proceeding.
- If the subnet exists, it utilizes the existing self.query_subtensor method to query the SubnetOwnerHotkey storage item on the Subtensor module with the provided netuid.
- Extracts the SS58 address from the query result.
- Includes a basic validation check using bittensor.utils.is_valid_ss58_address() to ensure the returned value is a valid SS58 address format.
- Returns the owner's hotkey as an SS58 string if successful, otherwise returns None (e.g., if the subnet doesn't exist or the returned data is invalid).
Placement: The method has been added logically within the Subtensor class, grouped near other subnet-related query methods like get_subnet_hyperparameters.

Benefits:

Provides a clear and dedicated method for fetching the subnet owner's hotkey.
Improves developer experience by abstracting the underlying query details.
Includes basic validation for robustness.

Closes #2796.

basfroman

Please add unit tests for these methods and test for new method in tests/e2e_tests/test_subtensor_functions.py
Thank you for contribution!

basfroman · 2025-04-11T16:26:38Z

bittensor/core/subtensor.py

+
+        # Assuming the query returns the SS58 address directly or an object with a value attribute
+        # Adjust based on the actual return type if needed
+        owner_hotkey = getattr(result, "value", result)


you don't need this check because self.query_subtensor returns None or str from this request

basfroman · 2025-04-11T16:28:04Z

bittensor/core/subtensor.py

+        if isinstance(owner_hotkey, str) and is_valid_ss58_address(owner_hotkey):
+            return owner_hotkey
+        else:
+            logging.error(


I'd consider to use debug level in this case

bittensor/core/async_subtensor.py

basfroman · 2025-04-11T16:31:45Z

bittensor/core/subtensor.py

+        # Check if the returned hotkey is valid (basic check)
+        if isinstance(owner_hotkey, str) and is_valid_ss58_address(owner_hotkey):
+            return owner_hotkey
+        else:


you don't need else in this step. pls see the comment suggestion for async method

bittensor/core/subtensor.py

basfroman · 2025-04-11T16:32:46Z

bittensor/core/subtensor.py

+        # Assuming the query returns the SS58 address directly or an object with a value attribute
+        # Adjust based on the actual return type if needed
+        owner_hotkey = getattr(result, "value", result)


the same as in async method suggestion

Co-authored-by: Roman <[email protected]>

gap-editor · 2025-04-11T17:07:31Z

@basfroman i will continue work on it today.

basfroman · 2025-04-11T17:13:25Z

@basfroman i will continue work on it today.

hey @gap-editor , pls fix my typo in the suggestion

instead of

block_hash+ = await self.determine_block_hash(block, block_hash, reuse_block)

use

block_hash_ = await self.determine_block_hash(block, block_hash, reuse_block)

basfroman · 2025-04-11T22:27:15Z

tests/unit_tests/test_subtensor.py

@@ -83,24 +83,35 @@ def test_methods_comparable(mock_substrate):

    # methods which lives in async subtensor only
    excluded_async_subtensor_methods = ["initialize"]
-    subtensor_methods = [m for m in dir(subtensor) if not m.startswith("_")]
+    subtensor_methods = [m for m in dir(subtensor) if not m.startswith("_") and callable(getattr(subtensor, m))]


and callable(getattr(subtensor, m))

we also check fields and properties too. remove it pls

basfroman · 2025-04-11T22:27:32Z

tests/unit_tests/test_subtensor.py

        m
        for m in dir(async_subtensor)
-        if not m.startswith("_") and m not in excluded_async_subtensor_methods
+        if not m.startswith("_") and m not in excluded_async_subtensor_methods and callable(getattr(async_subtensor, m))


the same as above

basfroman · 2025-04-11T22:27:59Z

tests/unit_tests/test_subtensor.py

+        assert hasattr(
+            async_subtensor, method
+        ), f"`Subtensor.{method}` not found as an attribute in `AsyncSubtensor` instance."
+        # Ensure the attribute is actually callable (a method)
+        assert callable(
+            getattr(async_subtensor, method)
+        ), f"Attribute `AsyncSubtensor.{method}` is not callable."
+
+    # Check if all relevant public methods in AsyncSubtensor exist in Subtensor
+    for method in async_subtensor_method_names:
+        assert hasattr(
+            subtensor, method
+        ), f"`AsyncSubtensor.{method}` not found as an attribute in `Subtensor` instance."
+        # Ensure the attribute is actually callable (a method)
+        assert callable(
+            getattr(subtensor, method)
+        ), f"Attribute `Subtensor.{method}` is not callable."


the same reason as above to reverse it back

basfroman · 2025-04-11T22:29:06Z

bittensor/core/subtensor.py

+        )
+        return None
+
+    def get_subnet_reveal_period_epochs(


we have this methods already. pls remove

this is the reason you have this failed ci/circleci: lint-and-type-check checkers

bittensor/core/subtensor.py:3520: error: Name "get_subnet_reveal_period_epochs" already defined on line 1657 [no-redef]

basfroman · 2025-04-11T22:31:47Z

bittensor/core/async_subtensor.py

+    async def get_subnet_owner_hotkey(
+        self,
+        netuid: int,
+        block: Optional[int] = None,
+        block_hash: Optional[str] = None,
+        reuse_block: bool = False,
+    ) -> Optional[str]:
+        """
+        Retrieves the hotkey of the owner for a specific subnet asynchronously.
+
+        Arguments:
+            netuid (int): The unique identifier of the subnet.
+            block (Optional[int]): The blockchain block number for the query. Do not specify if using block_hash or reuse_block.
+            block_hash (Optional[str]): The hash of the blockchain block number for the query. Do not specify if using block or reuse_block.
+            reuse_block (bool): Whether to reuse the last-used block hash. Do not set if using block_hash or block.
+
+        Returns:
+            Optional[str]: The SS58 address of the subnet owner's hotkey if the subnet exists, `None` otherwise.
+        """
+        block_hash_ = await self.determine_block_hash(block, block_hash, reuse_block)
+
+        if not await self.subnet_exists(
+            netuid, block_hash=block_hash_, reuse_block=reuse_block
+        ):
+            logging.debug(f"Subnet {netuid} does not exist.")
+            return None
+
+        owner_hotkey = await self.query_subtensor(
+            name="SubnetOwnerHotkey",
+            params=[netuid],
+            block_hash=block_hash_,
+            reuse_block=reuse_block,
+        )
+
+        if owner_hotkey is None:
+            # Should not happen if subnet_exists check passes, but handle defensively
+            return None
+
+        # Check if the returned hotkey is valid (basic check)
+        if is_valid_ss58_address(owner_hotkey):
+            return owner_hotkey
+
+        logging.error(
+            f"Received invalid owner hotkey format for subnet {netuid}: {owner_hotkey}"
+        )
+        return None


We try to arrange methods in alphabetical order by sections. Please place methods in the right place in the methods section. Thank you

I've double-checked, and the unit tests are already located in the correct alphabetical position within their section

I've double-checked, and the unit tests are already located in the correct alphabetical position within their section

I meant new methods get_subnet_owner_hotkey for Subtensor. Comment left to the method.
Unit tests look good. But there is an error in the test. One argument is missing - period = 5.

basfroman · 2025-04-11T22:31:53Z

bittensor/core/subtensor.py

+    def get_subnet_owner_hotkey(
+        self, netuid: int, block: Optional[int] = None
+    ) -> Optional[str]:
+        """
+        Retrieves the hotkey of the owner for a specific subnet.
+
+        Arguments:
+            netuid (int): The unique identifier of the subnet.
+            block (Optional[int]): The blockchain block number for the query.
+
+        Returns:
+            Optional[str]: The SS58 address of the subnet owner's hotkey if the subnet exists, `None` otherwise.
+        """
+        if not self.subnet_exists(netuid, block=block):
+            logging.debug(f"Subnet {netuid} does not exist.")
+            return None
+
+        owner_hotkey = self.query_subtensor( # Use result directly
+            name="SubnetOwnerHotkey", params=[netuid], block=block
+        )
+
+        if owner_hotkey is None:
+            # Should not happen if subnet_exists check passes, but handle defensively
+            return None
+
+        # Check if the returned hotkey is valid (basic check)
+        if is_valid_ss58_address(owner_hotkey):
+            return owner_hotkey
+
+        logging.debug(
+            f"Received invalid owner hotkey format for subnet {netuid}: {owner_hotkey}"
+        )
+        return None


We try to arrange methods in alphabetical order by sections. Please place methods in the right place in the methods section. Thank you

basfroman · 2025-04-11T22:33:40Z

to avoid ci/circleci: ruff checker failed, please use ruff format . command in your terminal within the repo directory

gap-editor · 2025-04-11T23:23:20Z

will continue work tommorow

basfroman · 2025-04-24T00:59:36Z

will continue work tommorow

Hey @gap-editor any updates?
If you are busy or for some reason you don't have time, feel free to let me know. I'll take this task.
We need to implement this in a short time.

gap-editor · 2025-04-24T16:23:28Z

hi. was little bit busy those days. i am going to take a look today. thanks and sorry for this delay

gap-editor · 2025-04-24T17:09:26Z

will continue work tommorow

Hey @gap-editor any updates? If you are busy or for some reason you don't have time, feel free to let me know. I'll take this task. We need to implement this in a short time.

I also have a question. could you please write down a list of tasks that I have to do? because due to my main job I am a bit out of context. i would be very grateful to you.

basfroman · 2025-04-24T20:08:01Z

will continue work tommorow

Hey @gap-editor any updates? If you are busy or for some reason you don't have time, feel free to let me know. I'll take this task. We need to implement this in a short time.

I also have a question. could you please write down a list of tasks that I have to do? because due to my main job I am a bit out of context. i would be very grateful to you.

I think you need to go through all my comments in this PR. By closing them accordingly you will reach your goal regarding this task.

gap-editor added 3 commits April 11, 2025 13:04

Update subtensor.py

b678d8d

Update async_subtensor.py

7e17f33

Update async_subtensor.py

a266a6e

basfroman requested changes Apr 11, 2025

View reviewed changes

basfroman changed the base branch from master to staging April 11, 2025 16:34

Merge branch 'staging' into master

62c0a8e

basfroman assigned gap-editor Apr 11, 2025

basfroman added the enhancement New feature or request label Apr 11, 2025

basfroman requested a review from ibraheem-abe April 11, 2025 16:35

Merge branch 'staging' into master

a193b55

gap-editor requested a review from basfroman April 11, 2025 17:06

gap-editor and others added 2 commits April 11, 2025 19:06

Update bittensor/core/subtensor.py

d385f55

Co-authored-by: Roman <[email protected]>

Update bittensor/core/async_subtensor.py

ef4cd79

Co-authored-by: Roman <[email protected]>

gap-editor added 7 commits April 11, 2025 19:22

Update async_subtensor.py

028f24f

Update subtensor.py

ab939df

Update async_subtensor.py

7d0d2f9

Merge branch 'staging' into master

55b95ab

Update async_subtensor.py

879322a

Update async_subtensor.py

9c86325

Update test_subtensor.py

3ed2c1d

basfroman requested changes Apr 11, 2025

View reviewed changes

gap-editor added 2 commits April 12, 2025 01:05

Update test_subtensor.py

235be6c

Update subtensor.py

1b1b1bb

Merge branch 'staging' into master

bb693eb

Update subtensor.py

680e05a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add get_subnet_owner_hotkey method to Subtensor #2815

feat: add get_subnet_owner_hotkey method to Subtensor #2815

gap-editor commented Apr 11, 2025

basfroman left a comment •

edited

Loading

basfroman Apr 11, 2025

basfroman Apr 11, 2025

basfroman Apr 11, 2025

basfroman Apr 11, 2025

gap-editor commented Apr 11, 2025

basfroman commented Apr 11, 2025

basfroman Apr 11, 2025

basfroman Apr 11, 2025

basfroman Apr 11, 2025

basfroman Apr 11, 2025 •

edited

Loading

basfroman Apr 11, 2025

gap-editor Apr 11, 2025

basfroman Apr 11, 2025

basfroman Apr 11, 2025

basfroman commented Apr 11, 2025 •

edited

Loading

gap-editor commented Apr 11, 2025

basfroman commented Apr 24, 2025

gap-editor commented Apr 24, 2025 via email •

edited

Loading

gap-editor commented Apr 24, 2025

basfroman commented Apr 24, 2025

feat: add get_subnet_owner_hotkey method to Subtensor #2815

Are you sure you want to change the base?

feat: add get_subnet_owner_hotkey method to Subtensor #2815

Conversation

gap-editor commented Apr 11, 2025

basfroman left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gap-editor commented Apr 11, 2025

basfroman commented Apr 11, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

basfroman Apr 11, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

basfroman commented Apr 11, 2025 • edited Loading

gap-editor commented Apr 11, 2025

basfroman commented Apr 24, 2025

gap-editor commented Apr 24, 2025 via email • edited Loading

gap-editor commented Apr 24, 2025

basfroman commented Apr 24, 2025

basfroman left a comment •

edited

Loading

basfroman Apr 11, 2025 •

edited

Loading

basfroman commented Apr 11, 2025 •

edited

Loading

gap-editor commented Apr 24, 2025 via email •

edited

Loading